This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
doc: add SetReportingPeriod recommendations #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
approved these changes
Sep 11, 2018
stats/view/worker.go
Outdated
| @@ -113,11 +113,15 @@ func record(tags *tag.Map, ms interface{}) { | |||
| ms: ms.([]stats.Measurement), | |||
| } | |||
| defaultWorker.c <- req | |||
| } | |||
| }; | |||
There was a problem hiding this comment.
Please remove this, this ain't Java 😂
| // the program. If duration is less than or equal to zero, it enables the | ||
| // default behavior. | ||
| // | ||
| // Note: each exporter makes different promises about what the lowest supported |
There was a problem hiding this comment.
Nice, thank you! It would be nice to also mail a change to the actual stackdriver exporter repo providing an advisory for this time duration.
There was a problem hiding this comment.
@songy23 I see you initially mailed census-ecosystem/opencensus-go-exporter-stackdriver#37 but closed it. Will you perhaps be making an update in light of this new PR?
There was a problem hiding this comment.
Yes, the Stackdriver example is already updated in census-ecosystem/opencensus-go-exporter-stackdriver#38.
|
PTAL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.