Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

improve W3C Trace Context compliance #934

Merged
merged 1 commit into from
Sep 27, 2018
Merged

improve W3C Trace Context compliance #934

merged 1 commit into from
Sep 27, 2018

Conversation

reyang
Copy link
Contributor

@reyang reyang commented Sep 25, 2018

redo PR #931

Trying to improve the compliance by fixing:

  1. Current version allows trace options to be optional, which is against https://github.com/w3c/distributed-tracing/blob/master/trace_context/HTTP_HEADER_FORMAT.md#traceparent-field.
  2. Current implementation doesn't combine multiple headers with the same name.
  3. Version compatibility.

@rghetia
Copy link
Contributor

rghetia commented Sep 25, 2018

From spec perspective it looks good.

/cc @Ramonza . He had some concern with go style.

@reyang
Copy link
Contributor Author

reyang commented Sep 27, 2018

@Ramonza would you help to review?

@semistrict semistrict merged commit ae11cd0 into census-instrumentation:master Sep 27, 2018
@reyang reyang deleted the w3c branch September 27, 2018 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants