Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Switch to Circle CI version 2.0 #176

Merged
merged 13 commits into from
Apr 19, 2018
Merged

Switch to Circle CI version 2.0 #176

merged 13 commits into from
Apr 19, 2018

Conversation

chingor13
Copy link
Member

@chingor13 chingor13 commented Apr 19, 2018

We can remove the gcloud dependency and credentials.

Also runs the tests against PHP 5.6

@chingor13 chingor13 requested a review from tmatsuo April 19, 2018 23:16
@@ -69,7 +69,7 @@ public function testRestoringCurrentContext()
}

/**
* @expectedException \PHPUnit\Framework\Error\Warning
* @expectedException PHPUnit_Framework_Error_Warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because of phpunit 5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunately

@chingor13 chingor13 merged commit b20205e into master Apr 19, 2018
@chingor13 chingor13 deleted the circle-2.0 branch April 19, 2018 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants