-
Notifications
You must be signed in to change notification settings - Fork 82
Add Integration tests #181
Add Integration tests #181
Conversation
tests/integration/curl/CurlTest.php
Outdated
|
||
public function testCurlExec() | ||
{ | ||
$url = 'https://www.google.com/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in here we could avoid this Google dependency. Would you consider to use something like https://github.com/jcchavezs/httptest-php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll skip this for now: jcchavezs/httptest-php#5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chingor13 I just opened a PR addressing this issue: jcchavezs/httptest-php#6
af9892a
to
d291506
Compare
@@ -77,12 +77,9 @@ public static function load() | |||
}); | |||
|
|||
// public function delete() | |||
opencensus_trace_method(Model::class, 'delete', function ($model, $query) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was broken and caught by integration tests - there is no parameter for query.
@@ -0,0 +1,3 @@ | |||
<?php | |||
|
|||
require __DIR__ . '/../vendor/autoload.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the only content, maybe you can just specify the autoload.php in the phpunit config file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
@@ -0,0 +1,3 @@ | |||
<?php | |||
|
|||
require_once __DIR__ . '/../vendor/autoload.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Add wordpress example/integration test run integration test in circle ci specify mysql:5.7 and only run integrations for now Skip batcache for wordpress Add memcached test Move wordpress test to integration, run memcached test Fix memcached extension loading. Wait for mysql container Fix php version for memcached test Parameterize memcache composer url Fix sed Fix composer branch Fix mysql start Put wp-config in correct location Add laravel integration test Fix laravel network, run migrations Fix database migration command Install pdo/pdo_mysql extensions Pass db credentials as env vars Fix docker run argument order Add eloquent database tests Try memcached test without docker Install memcached extension without prompts Fix test script name Combine laravel and wordpress tests into single integration test Ignore return code for file copy. Fix wordpress db config Cleanup missing vars Run curl tests in integrations Add guzzle5/6 tests Re-enable unit tests
a75184b
to
598a548
Compare
Adds an integration test to Circle CI
Note: to test the current branch, we replace the repo/branch in the composer.json before installing dependencies.
See #120