Add document about what to do with untrusted requests. #104
Conversation
bogdandrutu
requested review from
tsloughter,
codefromthecrypt,
rakyll,
semistrict,
songy23,
dinooliva,
sebright and
g-easy
|
I think we should also document what to do with outgoing requests to untrusted destinations. This is as much about egress as it is ingress. |
| `Sampler` interface to allow users to implement smart Samplers (e.g. high sampling probability if | ||
| the incoming untrusted request is sampled). | ||
|
|
||
| // DO_NOT_SUBMIT: take feedback what is better 2 default samplers in TraceConfig (one for trusted |
There was a problem hiding this comment.
User still needs to configure the entry points to tell the library incoming requests are not trusted. They can simply set a custom sampler at this point. I think we need to document it with examples for now rather than having two default samplers.
| customer request). | ||
|
|
||
| ## How does OpenCensus know if a request is trusted or not? | ||
| The OpenCensus library does not have a mechanism to determine if an incoming request is trusted |
There was a problem hiding this comment.
Add a paragraph explaining that the starting options should take an isTrusted bool option.
|
/cc @rghetia You will continue this work. Can I submit as it is and you deal with comments and make necessary changes? |
bogdandrutu
force-pushed
the
trusting
branch
from
4045092 to
539dbdc
Compare
sure. |
|
@rghetia all your now. thanks. |
This is an early draft and I would like to get feedback, we need to do the following: