Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Commit

Permalink
enh(GitHub): add more information (#7552)
Browse files Browse the repository at this point in the history
* doc(README): Add README to provide instructions for documentation

* enh(CONTRIBUTING.md): add section for the documentation

* enh(FEATURE_REQUEST.md): fully use the markdown language

* enh(ISSUE_TEMPLATE.md): ask for more information

* Asking for browser information
* Asking for logs
* Fully use the markdown syntax

* enh(PULL_REQUEST_TEMPLATE.md): fully use markdown syntax
  • Loading branch information
adr-mo authored May 21, 2019
1 parent 8b36c91 commit b8f3cd5
Show file tree
Hide file tree
Showing 5 changed files with 135 additions and 47 deletions.
6 changes: 3 additions & 3 deletions .github/FEATURE_REQUEST.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ Be aware that your feature request might not be taken into account for future de
Please describe your feature request in English.
-->

<h3> Feature explanation </h3>
### Feature explanation

A short explanation of the wanted feature

<h3> What is the value of the wanted feature ?</h3>
### What is the value of the wanted feature ?

A short explanation of what could be the value of the wanted feature.

<h3> Additional information </h3>
### Additional information

Dedicated section to add any information to make your case(*screenshots*, ...)
46 changes: 39 additions & 7 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ in the next 30 days, the ticket will be automaticaly closed.
Please describe your issue in English.
-->

<h1>BUG REPORT INFORMATION </h1>
# BUG REPORT INFORMATION

<h3> Prerequisites </h3>
### Prerequisites

> The opened issue, must be code related. GitHub is not meant for support. Feel free to check the CONTRIBUTING section for more details.
Expand All @@ -45,22 +45,54 @@ $ dpkg -l | grep centreon

*CentOS, Debian ...*

***Browser used***

- [ ] Google Chrome
- [ ] Firefox
- [ ] Internet Explorer IE11
- [ ] Safari

Version: --

***Additional environment details (AWS, VirtualBox, physical, etc.):***

<h3> Description </h3>
### Description

-- Describe the encountered issue --

<h3> Steps to Reproduce </h3>
### Steps to Reproduce

Please describe precisely the steps to reproduce the encountered issue.

1. I logged in Centreon
2. I reached the Custom View
3. And so on...

<h3> Describe the received result </h3>
### Describe the received result

### Describe the expected result

### Logs

**PHP error logs**

```
tail -f /var/opt/rh/rh-php71/log/php-fpm/centreon-error.log
```
**centreon-engine logs (*if needed*)**

<h3> Describe the expected result </h3>
```
tail -f /var/log/centreon-engine/centengine.log
```
**centreon-broker logs (*if needed*)**

```
tail -f /var/log/centreon-broker/central-broker-master.log
```
**centcore logs (*if needed*)**

```
tail -f /var/log/centreon/centcore.log
```

<h3> Additional relevant information (e.g. frequency, ...) </h3>
### Additional relevant information (e.g. frequency, ...)
20 changes: 10 additions & 10 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
<h1> Pull Request Template </h1>
# Pull Request Template

<h2> Description </h2>
## Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:
* **QA Team** (Quality Assurance) with tests.
* **reviewers** to understand what are the stakes of the pull request.

Fixes # (issue)
**Fixes** # (issue)

<h2> Type of change </h2>
## Type of change

- [ ] Patch fixing an issue (non-breaking change)
- [ ] New functionality (non-breaking change)
- [ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software
- [ ] Updating documentation (missing information, typo...)

<h2> Target serie </h2>
## Target serie

- [ ] 2.8.x
- [ ] 18.10.x
Expand All @@ -27,18 +27,18 @@ Please describe the **procedure** to verify that the goal of the PR is matched.

Any **relevant details** of the configuration to perform the test should be added.

<h2> Checklist </h2>
## Checklist

<h5> Community contributors & Centreon team </h5>
#### Community contributors & Centreon team

- [ ] I followed the **coding style guidelines** provided by Centreon
- [ ] I have commented my code, especially new **classes**, **functions** or any **legacy code** modified. (***docblock***)
- [ ] I have commented my code, especially **hard-to-understand areas** of the PR.
- [ ] I have made corresponding changes to the **documentation**.
- [ ] I have **rebased** my development branch on the base branch (master, maintenance).
- [ ] I have **rebased** my development branch on the base branch (master, maintenance).

<h5> Centreon team only </h5>
#### Centreon team only

- [ ] I have made sure that the **unit tests** related to the story are successful.
- [ ] I have made sure that **unit tests covers 80%** of the code written for the story.
- [ ] I have made sure that **unit tests cover 80%** of the code written for the story.
- [ ] I have made sure that **acceptance tests** related to the story are successful (**local and CI**)
59 changes: 32 additions & 27 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,39 +1,39 @@
<h1> Contributing to Centreon project </h1>
# Contributing to Centreon project

:clap: First thing first... Thank you for taking the time to contribute to Centreon project ! :clap: Much appreciated ! :metal:

This article contains guidelines for contributing to [Centreon](https://github.com/centreon/) project.

<h3>Table of contents </h3>
### Table of contents

[I have a question](#i-have-a-question-)

[How can I contribute?](#-how-can-i-contribute-)
* [Where should I report ?](#-where-shoud-i-report-)
* [I have an issue to report](#-i-have-an-issue-to-report-)
* [I have a suggestion of enhancement](#-i-have-a-suggestion-of-enhancement-)
* [I have a pull request to submit](#-i-have-a-pull-request-to-submit-)
- [Where should I report ?](#-where-shoud-i-report-)
- [I have an issue to report](#-i-have-an-issue-to-report-)
- [I have a suggestion of enhancement](#-i-have-a-suggestion-of-enhancement-)
- [I have a pull request to submit](#-i-have-a-pull-request-to-submit-)

[Centreon style guides](#-centreon-style-guides-)
* [Formating commit messages](#-formating-commit-messages-)
* [Coding style](#-coding-style-)
- [Formating commit messages](#-formating-commit-messages-)
- [Coding style](#-coding-style-)

<h2> Code of Conduct </h2>
## Code of Conduct

Any people that wants to contribute and participate in developping the project must respect [Centreon Code of Conduct](CODE_OF_CONDUCT.md). Please report any unacceptable behavior to [[email protected]](mailto:[email protected]).

<h2I have a question </h2>
## I have a question

> **Advise**: Centreon GitHub is meant for opening issues (code related), feature requests and so on. It is not **meant** for **support**. Please refer to the following available ressources, you'll get an answer from a Centreon team or community member.

* [Official Centreon Slack](https://centreon.github.io/register-slack)
- [Official Centreon Slack](https://centreon.github.io/register-slack)

<h2> How can I contribute </h2>
## How can I contribute

Centreon community can contribute in **many ways** to the project.

<h3> Where shoud I report ? </h3>
### Where shoud I report ?

Issues and feature requests should be done on the **appropriate repositories**. Here are the repositories maintened by Centreon:

Expand All @@ -60,27 +60,27 @@ Issues and feature requests should be done on the **appropriate repositories**.
| [centreon-widget-engine-status](https://github.com/centreon/centreon-widget-engine-status)


<h3> I have an issue to report </h3>
### I have an issue to report

Before reporting an issue please make sure that it has not been already reported by checking [Centreon Bug Tracker](https://github.com/centreon/centreon/issues)

If your issue has **not** been reported yet, then the issue should be opened using the following template [ISSUE_TEMPLATE.md](.github/ISSUE_TEMPLATE.md)

<h3> I have a suggestion of enhancement </h3>
### I have a suggestion of enhancement

Any ideas, enhancements, feature requests are more than welcome. Feature requests should be opened by using the following template [FEATURE_REQUEST.md](.github/FEATURE_REQUEST.md)

<h3> I have a pull request to submit </h3>
### I have a pull request to submit

You have been working on Centreon base code and want to submit it to us. Well... Again you are more than welcome and thank you in advance ! :clap:

The pull request should respect the some requirements that can found in the following template [PULL_REQUEST_TEMPLATE.md](.github/PULL_REQUEST_TEMPLATE.md)

> **Notice**: Any pull request that does not respect those requirements will be legitimately rejected !
<h3> Centreon style guides </h3>
### Centreon style guides

<h4> Formating commit messages </h4>
#### Formating commit messages

The commit format should follow this commit template message
```
Expand All @@ -101,18 +101,18 @@ Applied to the sample ticket
Refs: #5567 (GitHub) or MON-2234 (Jira)
```
The ***type*** can refer to
* **feat**: adding a feature
* **fix**: adding a patch
* **enh**: adding an enhancement
* **docs**: adding documentation changes
* **style**: fixing coding style issues
* **refactor**: code refactoring
* **test**: adding new tests or fixing old ones
* **chore** : updating project construction files (Jenkins files, CMakefile, gulp, webpack ...)
- **feat**: adding a feature
- **fix**: adding a patch
- **enh**: adding an enhancement
- **docs**: adding documentation changes
- **style**: fixing coding style issues
- **refactor**: code refactoring
- **test**: adding new tests or fixing old ones
- **chore** : updating project construction files (Jenkins files, CMakefile, gulp, webpack ...)

The ***scope*** is defined by project. Scopes for Centreon Open Source project can be found [here](scopes/centreon.md).

<h4> Coding style </h4>
#### Coding style

Centreon software is made of several languages. For each language a specific coding style **must be respected**.

Expand All @@ -124,6 +124,11 @@ For other languages, coding style rules are defined in Centreon GitHub repositor
* [HTML](https://github.com/centreon/centreon/tree/master/doc/coding-style/html)
* [JavaScript](https://github.com/centreon/centreon/tree/master/doc/coding-style/js)

#### Documentation

If you want to visualize and suggest modification to the documentation through a pull request
you can check the **HOW TO** build the documentation section [here](doc/README.md)




Expand Down
51 changes: 51 additions & 0 deletions doc/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Centreon documentation

The official **Centreon documentation** can be found [here](https://documentation.centreon.com/docs/centreon/en/latest/)

It is possible to build the **official** Centreon documentation if you want to visualize it
or make some modifications.

## Prerequisite

You will need to install a python dependency.

On **debian based** distributions
```
sudo apt-get install python-sphinx
```
On **RedHat based** distributions
```
sudo yum install python-sphinx
```
On **Arch based** distributions
```
sudo pacman -S python-sphinx
```

## Compile

Once the dependency installed you will have to compile the documentation either the
French or English version. For the example lets compile the English version.

Go to the directory:
```
cd en/
```

Then compile:
```
make clean ; make html
```

We can use python to serve the `_build/html` directory and visualize the built documentation

If you are running **python2**:
```
cd _build/html
python -m SimpleHTTPServer
```
If you are running **python3**:
```
cd _build/html
python3 -m http.server
```

0 comments on commit b8f3cd5

Please sign in to comment.