This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(install): check mariaDB version before using ALTER USER #8068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
commented
Oct 28, 2019
| $versionName = $row['version_comment']; | ||
| } | ||
| } | ||
| if ((strpos($versionName, "MariaDB") !== false && version_compare($versionNumber, '10.2.0') >= 0) |
There was a problem hiding this comment.
I'm not sure that we need to ALTER the centreon's user, on a MariaDB, as the deprecated "plugin" problem may affect only mysql >= 8.0
lgcosta
approved these changes
Oct 29, 2019
kduret
reviewed
Oct 29, 2019
kduret
approved these changes
Oct 29, 2019
loiclau
approved these changes
Oct 29, 2019
sc979
added a commit
that referenced
this pull request
Nov 5, 2019
* fix(install): avoid trying to use the ALTER USER on a mariaDB < 10.2 * enh(BE): remove the useless prepare statement
sc979
added a commit
that referenced
this pull request
Nov 6, 2019
* fix(install): avoid trying to use the ALTER USER on a mariaDB < 10.2 * enh(BE): remove the useless prepare statement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
As the Centreon wasn't released with the mariaDB 10.2 as expected, the MySQL 8.0 modifications are incompatible with mariaDB 10.1.
As the ALTER USER clause were introduced on the mariaDB 10.2.
Resulting in an error blocking the installation script on a fresh install
Fixes # (blocking)
Type of change
Target serie
How this pull request can be tested ?
Try to install a fresh install using the current RPM -> an error occurs and you can't acheive the installation
Apply the fix, then try again -> The installation should work as expected
Checklist
Community contributors & Centreon team
Centreon team only