Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: separate integration tests utils #1216

Merged
merged 1 commit into from
Feb 27, 2023
Merged

refactor: separate integration tests utils #1216

merged 1 commit into from
Feb 27, 2023

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Feb 27, 2023 •
edited
Loading

Description

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

cargo test --package runtime-integration-tests

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I rebased on the latest main branch

@wischli wischli self-assigned this Feb 27, 2023
@wischli wischli added the D0-ready Pull request can be merged without special precaution and notification. label Feb 27, 2023
mustermeiszer
mustermeiszer approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@mustermeiszer mustermeiszer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care do fast!

@wischli wischli merged commit d2a6abc into main Feb 27, 2023
@lemunozm lemunozm deleted the refactor/ci-utils branch February 27, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustermeiszer mustermeiszer mustermeiszer approved these changes

@branan branan Awaiting requested review from branan

Assignees

@wischli wischli

Labels
D0-ready Pull request can be merged without special precaution and notification.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract integration-tests utils
2 participants
@wischli @mustermeiszer