Add benchmark CI job for fast checks #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
D0-ready
lemunozm
requested review from
mikiquantum,
mustermeiszer,
branan and
NunoAlexandre
as code owners
mustermeiszer
previously approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Looks good to me! But given we change CI I would also wait for @gpmayorga approval
|
This PR fails as expected due to the Once that PR is merged, this can be safety merged. |
|
I think we can run better the three runtimes in the same job to save 1 hour per CI job |
lemunozm
force-pushed
the
ci-benchmark-checks
branch
from
3b86366 to
d8c213c
Compare
lemunozm
force-pushed
the
ci-benchmark-checks
branch
from
d8c213c to
887b0a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This job does not generate weights, it only checks fastly for all runtimes if benchmarks work/compile.
You can test the script locally as follows for fast benchmark checks (it takes around 10-15s to check all runtime benchmarks once it's compiled):
Being
<runtime>the following possible values:development,altair,centrifugeFixes #1268
Changes and Descriptions