-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Altair Release 1026 & Development Release 1019 #1302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustermeiszer
added
the
D2-notify
Pull request can be merged and notification about changes should be documented.
label
Apr 4, 2023
branan
force-pushed
the
feature/altair-1026
branch
from
April 5, 2023 02:09
232119b
to
f0f7a0e
Compare
Rebased this - should be able to merge tomorrow if we want to land this as part of the release. |
branan
force-pushed
the
feature/altair-1026
branch
from
April 5, 2023 02:31
f0f7a0e
to
9cd3270
Compare
wischli
requested review from
branan,
mikiquantum,
NunoAlexandre and
hieronx
as code owners
April 5, 2023 07:22
wischli
changed the title
Altair Release 1026
Altair Release 1026 & Development Release 1019
Apr 5, 2023
wischli
reviewed
Apr 5, 2023
fn on_runtime_upgrade() -> frame_support::weights::Weight { | ||
Scheduler::migrate_v2_to_v4() | ||
Scheduler::migrate_v3_to_v4() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Develop on 1018
has Scheduler.PalletVersion(3)
. Thus, we need to migrate to V4.
Altair 1025
and Centrifuge 1017
are already up-to-date on V4.
hieronx
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1026
1019
SchedulerMigration
Merge after: #1285 + #1299