-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker workflow #1320
Update docker workflow #1320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ff6fa60
to
5961aa3
Compare
5961aa3
to
cc3b83e
Compare
I'd consider this ready to merge pending the decision if we want to go for the 4-core option (1h 15min build time) or the 8-core option (45 min build time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the 4-core docker build (72 min = 1.152$) is a bit more cost-efficient than the 8-core (42 min = 1.344$), this seems to be the way.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Changes and Descriptions
[List your changes here]
Checklist: