fix: ethereum transaction pallet must forward to pallet-ethereum::transact #1536
Conversation
mustermeiszer
added
the
D0-ready
| TransactionSignature::new( | ||
| TRANSACTION_RECOVERY_ID, | ||
| H256::from_low_u64_be(1u64), | ||
| H256::from_low_u64_be(1u64), | ||
| H256::from_low_u64_be(2u64), |
There was a problem hiding this comment.
Just want to make sure this bump is intended? If you have the time, would be interested what this number reflects as the type is quite opaque:
pub struct TransactionSignature {
v: TransactionRecoveryId,
r: H256,
s: H256,
}There was a problem hiding this comment.
I just wanted the signature to not match the one from pallet-xcm-transactor. I have to be honest, no clue whether this makes snese. The signature is not checked, so I guess it is not really relevant.
There was a problem hiding this comment.
All right, thanks nevertheless!
pallets/liquidity-pools/src/lib.rs
Outdated
| /// An incoming LP message was | ||
| /// detected and is further processed | ||
| IncomingMessage { | ||
| sender: DomainAddress, | ||
| msg: MessageOf<T>, | ||
| }, |
There was a problem hiding this comment.
On a note: I would like to introduce the opposite OutgoingMessage enum event in #1473
There was a problem hiding this comment.
Should I also add it here do you mean? In this PR?
There was a problem hiding this comment.
No, not at all. I should have been more explicit. I wanted to express I am happy the opposite of my planned Event impl for Liquidity Pools will be implemented by this PR as this is a good signal for my plans.
mustermeiszer
requested review from
NunoAlexandre and
cdamian
as code owners
Description
Axelar depends on the
pallet_ethereum::Event<T>::Transact{..}and we were previsoulsy shortcircuting the logic, which lead to the event missing. This change fixes that behaviour and just generates the same origin as the runtime and forwards directly topallet-ethereum.Changes and Descriptions
pallet-ethereum::Pallet::<T>::transact(..)Checklist: