Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routers: Drop LP contract call from Axelar message #1545

Merged
merged 3 commits into from
Sep 13, 2023
Merged

routers: Drop LP contract call from Axelar message #1545

merged 3 commits into from
Sep 13, 2023

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Sep 12, 2023 •
edited
Loading

Description

Dropping the explicit call to the LP contract since our testing revealed that it is unnecessary.

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

mustermeiszer
mustermeiszer previously approved these changes Sep 12, 2023
View reviewed changes
@mustermeiszer
Copy link
Collaborator

please bumb dev runtime version to 24

@mustermeiszer
Copy link
Collaborator

lets merge this one into #1538 or #1538 before that.

NunoAlexandre
NunoAlexandre previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment on a doc

pallets/liquidity-pools-gateway/routers/src/routers/axelar_evm.rs Outdated Show resolved Hide resolved
pallets/liquidity-pools-gateway/routers/src/routers/axelar_evm.rs Show resolved Hide resolved
@cdamian cdamian force-pushed the fix/axelar-message-drop-lp-contract branch from f56a1ef to ce69f22 Compare September 12, 2023 12:59
wischli
wischli previously approved these changes Sep 12, 2023
View reviewed changes
@cdamian cdamian force-pushed the fix/axelar-message-drop-lp-contract branch from ce69f22 to 77eefda Compare September 12, 2023 15:45
@cdamian
Copy link
Contributor Author

cdamian commented Sep 12, 2023

Tested successfully on moonbase-dev.

NunoAlexandre
NunoAlexandre previously approved these changes Sep 12, 2023
View reviewed changes
@cdamian cdamian dismissed stale reviews from NunoAlexandre and wischli via 3de68b5 September 12, 2023 21:09
@cdamian cdamian force-pushed the fix/axelar-message-drop-lp-contract branch from 77eefda to 3de68b5 Compare September 12, 2023 21:09
mustermeiszer
mustermeiszer approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@mustermeiszer mustermeiszer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdamian cdamian merged commit 597eb77 into main Sep 13, 2023
@cdamian cdamian deleted the fix/axelar-message-drop-lp-contract branch September 13, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustermeiszer mustermeiszer mustermeiszer approved these changes

@wischli wischli wischli left review comments

@NunoAlexandre NunoAlexandre NunoAlexandre left review comments

@lemunozm lemunozm Awaiting requested review from lemunozm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdamian @mustermeiszer @NunoAlexandre @wischli