Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add moonbeam alpha spec, remove algol #1587

Merged
merged 3 commits into from
Oct 9, 2023
Merged

refactor: add moonbeam alpha spec, remove algol #1587

merged 3 commits into from
Oct 9, 2023

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Oct 9, 2023

Description

Extends #1585

  • Adds Moonbase Alpha relay chain config
  • Removes Algol remnants
  • Removes testnet-runtime feature which was only used for Algol

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli added D0-ready Pull request can be merged without special precaution and notification. P7-asap Issue should be addressed in the next days. I6-refactoring Code needs refactoring. I11-cleaning No mandatory issue that leave the repo more readable/organized I12-ci Issue related to CI labels Oct 9, 2023
@wischli wischli self-assigned this Oct 9, 2023
lemunozm
lemunozm approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all those red lines. Thanks for the clean up!

@wischli wischli enabled auto-merge (squash) October 9, 2023 11:28
NunoAlexandre
NunoAlexandre approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@wischli wischli force-pushed the wf/moonbeam-dev-spec branch from 0dbb08b to 04f9166 Compare October 9, 2023 13:17
@wischli wischli merged commit 74aeeb1 into main Oct 9, 2023
10 checks passed
This was referenced Oct 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemunozm lemunozm lemunozm approved these changes

@NunoAlexandre NunoAlexandre NunoAlexandre approved these changes

@mustermeiszer mustermeiszer Awaiting requested review from mustermeiszer mustermeiszer is a code owner

@hieronx hieronx Awaiting requested review from hieronx hieronx is a code owner

Assignees

@wischli wischli

Labels
D0-ready Pull request can be merged without special precaution and notification. I6-refactoring Code needs refactoring. I11-cleaning No mandatory issue that leave the repo more readable/organized I12-ci Issue related to CI P7-asap Issue should be addressed in the next days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wischli @NunoAlexandre @lemunozm