-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock builder: use foss3 dependency #1592
Conversation
9223ea3
to
418a325
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at that huge block of removed lines feels awesome!
@@ -23,7 +23,7 @@ sp-std = { git = "https://github.com/paritytech/substrate", default-features = f | |||
[dev-dependencies] | |||
cfg-mocks = { path = "../mocks" } | |||
cfg-types = { path = "../types" } | |||
mock-builder = { path = "../../libs/mock-builder" } | |||
mock-builder = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When @NunoAlexandre ends with the update I wanted to do it massively in all our repo
Description
Removes the inner
mock-builder
dependency and uses thefoss3
dependency.@NunoAlexandre a version of
0.9.43
is already available forfoss3
when you need to update the dependency: https://github.com/foss3/runtime-pallet-library/tree/polkadot-v0.9.43Fixes #1591