Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiquidityPools: Add restriction_set field to AddTranche message #1610

Merged
merged 2 commits into from
Nov 20, 2023
Merged

LiquidityPools: Add restriction_set field to AddTranche message #1610

merged 2 commits into from
Nov 20, 2023

Conversation

NunoAlexandre
Copy link
Contributor

Description

When adding a tranche token to a LP-compatible domain, we now need to specify which implementation of the RestrictionManager we want to use on a per-tranche-token basis. For that, we add this new field that serves as an identifier that will be picked up on the destination accordingly.

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@NunoAlexandre NunoAlexandre self-assigned this Nov 20, 2023
hieronx
hieronx reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@hieronx hieronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have someone else also review, but logically looks good to me!

@wischli wischli added P5-soon Issue should be addressed soon. D2-notify Pull request can be merged and notification about changes should be documented. I8-enhancement An additional feature. labels Nov 20, 2023
wischli
wischli approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am a bit hesitant on not adding it to the add_tranche extrinsic parameter set but it wouldn't make sense as long as its fixed to one.

@NunoAlexandre NunoAlexandre merged commit c49ac60 into main Nov 20, 2023
8 checks passed
@NunoAlexandre NunoAlexandre deleted the lp/add-tranche-restriction-set branch November 20, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieronx hieronx hieronx left review comments

@wischli wischli wischli approved these changes

@mustermeiszer mustermeiszer Awaiting requested review from mustermeiszer

Assignees

@NunoAlexandre NunoAlexandre

Labels
D2-notify Pull request can be merged and notification about changes should be documented. I8-enhancement An additional feature. P5-soon Issue should be addressed soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NunoAlexandre @hieronx @wischli