Sanity checks: re-activate Taplo #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking the ownership of this |
lemunozm
force-pushed
the
enable-taplo-checks
branch
from
e680848 to
0a447ee
Compare
lemunozm
requested review from
mustermeiszer,
NunoAlexandre,
hieronx,
wischli and
lemunozm
as code owners
gpmayorga
added
the
D0-ready
|
@gpmayorga could you give an approval? should be ready EDIT: forgot your're the only one that is not on the owner list 😆 |
lemunozm
force-pushed
the
enable-taplo-checks
branch
from
6168acb to
243674c
Compare
|
@wischli I do not know why your approval is mandatory here |
wischli
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
@gpmayorga Added me as secondary GHA owner to reduce the bus factor. Thanks a lot for the fix! Enjoy your weekend!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.