Remove dependency warnings due to codec aliases in workspace dependencies
#1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q0-trivial
lemunozm
requested review from
mustermeiszer,
NunoAlexandre,
wischli,
cdamian and
hieronx
as code owners
wischli
previously approved these changes
Dec 18, 2023
|
Added the change to all pallets. I've done it automatically with a script, so maybe some line has become quite long. Should now be ready to be merged! |
wischli
approved these changes
Dec 18, 2023
mustermeiszer
approved these changes
Dec 18, 2023
NunoAlexandre
approved these changes
Dec 19, 2023
|
@cdamian I think we need yours too 🙏🏻 |
hieronx
approved these changes
Dec 19, 2023
|
Force merging as @cdamian is on vacation and all others are approving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After some crates use workspace dependency, we are seeing a lot of warnings when compiling, this cargo issue. It seems that it can not have an alias dependency if using workspace dependencies. This PR adds support to use the original dependency name instead of the aliased one.
Changes and Descriptions
codecbyparity-scale-codecin crates that are currently using workspace dependencies.codecbyparity-scale-codecinlibs/*crates (for future workspace usage)codecbyparity-scale-codecinpallets/*crates (for future workspace usage)