Loans: Integration with OracleV2 #1658
Conversation
lemunozm
added
Q5-hard
lemunozm
requested review from
mustermeiszer,
NunoAlexandre,
wischli,
cdamian and
hieronx
as code owners
| parameter_types! { | ||
| pub const MaxActiveLoansPerPool: u32 = 300; | ||
| pub const MaxRateCount: u32 = MaxActiveLoansPerPool::get(); | ||
| pub const MaxCollectionSize: u32 = MaxActiveLoansPerPool::get(); | ||
| pub const MaxRateCount: u32 = 300; // See #1024 |
There was a problem hiding this comment.
@lemunozm briefly looked at the issue, but why does this now not need to be bound by the maximum number of active loans per pool? Shouldn't that still be the upper limit?
There was a problem hiding this comment.
Ahh, I see. I would still set it to MaxActiveLioansperpool to not misconfigure it accidently, wdyt?
There was a problem hiding this comment.
I would forget to comment on that!
As far as I know, MaxRateCount should be greater than MaxActiveLoansPerPool. If not, if one pool reaches MaxActiveLoansPerPool, there are no more rates available for other pools. That's why I maintain the value (by now) but disassociate it from MaxActiveLoansPerPool.
There was a problem hiding this comment.
I've comment this into issue #1024 to track this change
There was a problem hiding this comment.
IIRC we restrict the rate to be between 100.00 and 0, so we have a max amount of rates equal to 10001.
What would be the weight of that? Shouldn't we just allow that maximum?
There was a problem hiding this comment.
Ohh, I didn't think about that inherent limitation from the rate limitation.
Then, yes, we can use that value if we're sure that computing a pow over 10000 elements does not exceed the block limit. We would need to perform a benchmark first.
I would go with this for another PR, where we first make a benchmark for the worst case. Do you agree? Actually, it can be an update for the #1024 issue.
There was a problem hiding this comment.
Idea:
We can even create an utility method for it, which can be called from the runtime as follows:
type MaxCountRate = InterestAccrual::get_max_rate_count(0.25, MAXIMUM_BLOCK_WEIGHT)returning the exact value to not overpass the 25% of the block limit.
There was a problem hiding this comment.
That would be great!! Agreed with all above!
|
Thanks for your review @mustermeiszer in your free time! |
Description
This PR makes loans to use OracleV2.
Changes and Descriptions
pallet-loanswith the new one.DataFeederandDataProviderfrom orml traits and simplify loan benchmarkspallet-loansutilitiesValueProviderimplementation under runtime-benchmarks for pallet-oracle-data-collection in order to set benchmarking states using the feeder. (required for loans or users ofDataRegistrytraits)Migration(we do not have storage in Centrifuge/Altair) 🥳pallet-data-collectorcode from database