remarks: Add remarks pallet #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdamian
force-pushed
the
1647-feat-on-chain-remarks
branch
from
d4412bc to
71e2ddd
Compare
lemunozm
reviewed
Dec 26, 2023
cdamian
force-pushed
the
1647-feat-on-chain-remarks
branch
7 times, most recently
from
d948759 to
ffbfc5d
Compare
|
Pallet added here - foss3/runtime-pallet-library#18 |
|
Should this PR be closed and only reviewed/merged the one from |
No, the plan is to add the remarks pallet to the |
|
Oh I didn't see that the content of this PR has been changed, ok! |
cdamian
force-pushed
the
1647-feat-on-chain-remarks
branch
2 times, most recently
from
43476fa to
f88d21a
Compare
cdamian
commented
Jan 3, 2024
|
/benchmark development |
cdamian
force-pushed
the
1647-feat-on-chain-remarks
branch
from
f88d21a to
91228db
Compare
mustermeiszer
added
the
D0-ready
|
Started benchmarks manually. Can we also already bring this to mainnet please. Otherwise looks good! |
wischli
added
P7-asap
cdamian
force-pushed
the
1647-feat-on-chain-remarks
branch
from
91228db to
c0d7b76
Compare
cdamian
requested review from
mustermeiszer,
NunoAlexandre and
hieronx
as code owners
cdamian
force-pushed
the
1647-feat-on-chain-remarks
branch
from
c0d7b76 to
2659849
Compare
cdamian
force-pushed
the
1647-feat-on-chain-remarks
branch
from
2659849 to
7764cd6
Compare
|
I manually added the weights that we generated here |
mustermeiszer
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a pallet that's used for adding specific remarks to a call.
Fixes #1647
Checklist: