Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liquidity-pools: Add support for DisallowInvestmentCurrency message #1686

Merged
merged 2 commits into from
Jan 10, 2024
Merged

liquidity-pools: Add support for DisallowInvestmentCurrency message #1686

merged 2 commits into from
Jan 10, 2024

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Jan 9, 2024 •
edited
Loading

Description

Fixes #1649

Changes and Descriptions

Add support for the DisallowInvestmentCurrency LP message.

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@cdamian cdamian force-pushed the 1649-feat-enable-disallowinvestmentcurrency-for-liquidity-pools branch from 2be6067 to 884bde6 Compare January 9, 2024 16:20
@cdamian cdamian marked this pull request as ready for review January 9, 2024 16:20
@cdamian cdamian force-pushed the 1649-feat-enable-disallowinvestmentcurrency-for-liquidity-pools branch from 884bde6 to 2cd1bbd Compare January 9, 2024 16:22
@cdamian cdamian changed the title liquidity-pools: Add support for message liquidity-pools: Add support for DisallowInvestmentCurrency message Jan 9, 2024
wischli
wischli previously approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thorough as a detective, clean as a whistle!

pallets/liquidity-pools/src/message.rs Show resolved Hide resolved
runtime/integration-tests/src/generic/cases/liquidity_pools.rs Outdated Show resolved Hide resolved
@wischli wischli added I8-enhancement An additional feature. D2-notify Pull request can be merged and notification about changes should be documented. labels Jan 10, 2024
@wischli wischli merged commit 976d636 into main Jan 10, 2024
9 checks passed
@cdamian cdamian deleted the 1649-feat-enable-disallowinvestmentcurrency-for-liquidity-pools branch January 10, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustermeiszer mustermeiszer mustermeiszer approved these changes

@wischli wischli wischli left review comments

@lemunozm lemunozm Awaiting requested review from lemunozm

Assignees

@cdamian cdamian

Labels
D2-notify Pull request can be merged and notification about changes should be documented. I8-enhancement An additional feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Enable DisallowInvestmentCurrency for Liquidity Pools
3 participants
@cdamian @wischli @mustermeiszer