refactor: assign pool fee id during propose #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wischli
added
I3-annoyance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a pool fee to an existing pool is a two step process of proposing and applying (after success of the
ChangeGuard). Right now, the pool fee id is assigned as part of the second step such that it is unknown in between proposing and applying. This PR fixes this by assigning an id already during the proposing step. The id is exposed via theProposedevent dispatch.Another benefit from this refactor is that two same
PoolFeeInfos are now encoded as a uniqueChange. Beforehand, they would have been the same which is an uncaught error.Checklist: