Set correct onchain versions #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q1-easy
lemunozm
changed the title
lemunozm
force-pushed
the
release/oracle-versions
branch
from
8189052 to
b617f08
Compare
lemunozm
force-pushed
the
release/oracle-versions
branch
from
b617f08 to
10fb26e
Compare
lemunozm
changed the title
|
I think this changes are not required to |
wischli
approved these changes
Apr 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
=======================================
Coverage 47.70% 47.70%
=======================================
Files 170 170
Lines 13576 13576
=======================================
Hits 6477 6477
Misses 7099 7099 ☔ View full report in Codecov by Sentry. |
|
But when adding an external pallet, it always starts with the version it has, not 0 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm not sure why the new Oracle pallets added have their on-chain version of 0 when it should be 1. It is not an issue now, but it can be if we update them tomorrow, and makes the new Ci job for migrations fail. This PR set them with the correct version.
My hypothesis of why this has happened is that we reused the previous indexes from the previous oracle pallets (
orml-oracle, andpallet-data-collection), and because of this, it has not update the version (even when the pallet names have changed).The same happens for
OrderbookandForeignInvestmentsforaltair. Altair didn't require reseting the storage but we did not update the version numbers there.