Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: mostly non failable runtime-api #1810

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Fix: mostly non failable runtime-api #1810

merged 3 commits into from
Apr 15, 2024

Conversation

mustermeiszer
Copy link
Collaborator

Description

The NAV runtime-apis need to be super stable for the UI. This defaults them to use the latest computed price if the latest calculation fails.

Changes and Descriptions

  • use previously computed valuation amount for nav_loans
  • use previously computed valuation amount for nav_fees

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

lemunozm
lemunozm requested changes Apr 15, 2024
View reviewed changes
runtime/common/src/lib.rs Outdated Show resolved Hide resolved
@mustermeiszer mustermeiszer enabled auto-merge (squash) April 15, 2024 13:00
@mustermeiszer mustermeiszer merged commit c63c370 into main Apr 15, 2024
10 checks passed
wischli
wischli reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late for the party.. thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli left review comments

@lemunozm lemunozm lemunozm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustermeiszer @lemunozm @wischli