Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.11.0 #1868

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Release v0.11.0 #1868

merged 6 commits into from
Jun 11, 2024

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Jun 7, 2024 •
edited by mustermeiszer
Loading

Description

Release candidate for v0.11.0

Changes and Descriptions

  • Changes node/runtime crate and spec versions to be the same for all runtimes
  • Result from Engineering Offsite because we had too many different versions and runtimes are for externals to follow

TODO

  • Execute Benchmarks
  • Push Benchmarks
  • Generate WASM
  • Update Dev
  • Update Demo

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli added the I9-release A specific release. label Jun 7, 2024
@wischli wischli added this to the Centrifuge 1029 milestone Jun 7, 2024
@wischli wischli self-assigned this Jun 7, 2024
lemunozm
lemunozm previously approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Much simpler

wischli
wischli commented Jun 7, 2024
View reviewed changes
runtime/centrifuge/src/migrations.rs
// 4dTeMxuPJCK7zQGhFcgCivSJqBs9Wo2SuMSQeYCCuVJ9xrE2 --> 5Fc9NzKzJZwZvgjQBmSKtvZmJ5oP6B49DFC5dXZhTETjrSzo
// 4dTeMxuPJCK7zQGhFcgCivSJqBs9Wo2SuMSQeYCCuVJ9xrE2 --> 5CSfibAR9HHEwKpXbdsDHguAmLgKS6yKat2joTLA75DZ152L
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily, only the comment was off. The hex is correct, see @lemunozm's original commit: f457f22#diff-99b28d05634bd6aa324ac36d08291a48d92664bbe2eef597f04ee84ec9e8de0aL56

I verified this using Chopsticks pre and post RU execution.

The reason the comment is off because subkey inspect $hex assumes the hex to be a private key, I should have used subkey inspect $hex --public instead:

❯ subkey inspect "0x10c03288a534d77418e3c19e745dfbc952423e179e1e3baa89e287092fc7802f" --public
Network ID/Version: substrate
  Public key (hex):   0x10c03288a534d77418e3c19e745dfbc952423e179e1e3baa89e287092fc7802f
  Account ID:         0x10c03288a534d77418e3c19e745dfbc952423e179e1e3baa89e287092fc7802f
  Public key (SS58):  5CSfibAR9HHEwKpXbdsDHguAmLgKS6yKat2joTLA75DZ152L
  SS58 Address:       5CSfibAR9HHEwKpXbdsDHguAmLgKS6yKat2joTLA75DZ152L
❯ subkey inspect 5Fc9NzKzJZwZvgjQBmSKtvZmJ5oP6B49DFC5dXZhTETjrSzo
Public Key URI `5Fc9NzKzJZwZvgjQBmSKtvZmJ5oP6B49DFC5dXZhTETjrSzo` is account:
  Network ID/Version: substrate
  Public key (hex):   0x9caf39a5c322253288007349ea052d49d16f5344a94c4879d9e185404fb93851
  Account ID:         0x9caf39a5c322253288007349ea052d49d16f5344a94c4879d9e185404fb93851
  Public key (SS58):  5Fc9NzKzJZwZvgjQBmSKtvZmJ5oP6B49DFC5dXZhTETjrSzo
  SS58 Address:       5Fc9NzKzJZwZvgjQBmSKtvZmJ5oP6B49DFC5dXZhTETjrSzo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment!

@wischli wischli marked this pull request as ready for review June 10, 2024 10:51
@wischli wischli requested a review from hieronx as a code owner June 10, 2024 10:51
lemunozm
lemunozm approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Like a lot the new versioning method 🚀

mustermeiszer
mustermeiszer approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@mustermeiszer mustermeiszer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weights are update, all is good, right?

@lemunozm lemunozm merged commit b1a000b into main Jun 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustermeiszer mustermeiszer mustermeiszer approved these changes

@lemunozm lemunozm lemunozm approved these changes

@hieronx hieronx Awaiting requested review from hieronx hieronx is a code owner

Assignees

@wischli wischli

Labels
I9-release A specific release.
Projects
None yet
Milestone
Centrifuge 1029
Development

Successfully merging this pull request may close these issues.
3 participants
@wischli @lemunozm @mustermeiszer