Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FMT linter #1871

Merged
merged 0 commits into from
Jun 13, 2024
Merged

Fix FMT linter #1871

merged 0 commits into from
Jun 13, 2024

Conversation

gpmayorga
Copy link
Contributor

@gpmayorga gpmayorga commented Jun 13, 2024

Description

For some reason the FMT linter is broken in main and thus all PRs merging from main are failing to pass the linter.
The only plausible explanation is that the FMT version has changed and not has a default rule that is different from the past because some of the code changes suggested by fmt are lines from years ago.

@gpmayorga
Copy link
Contributor Author

It's still puzzling that it woulnd't have failed in on of the previous PRs and made it to main because the way I udnerstand rust the fmt version is totally pinned down?

@lemunozm
Copy link
Contributor

lemunozm commented Jun 13, 2024

The only plausible explanation is that the FMT version has changed

Agree. I can not figure out another option.

It's still puzzling that it woulnd't have failed in on of the previous PRs and made it to main because the way I udnerstand rust the fmt version is totally pinned down?

Here is my hypothesis. We now configure the toolchain for stable rust. But we still want to use the nightly capabilities of cargo fmt (that why we use +nightly). But when fetching the nightly version associated, because the nightly does not belong to the toolchain it's not pinned down.

But if that is true, I do not know how to fix it. Maybe forcing installing some nightly tagged version (?)

@lemunozm lemunozm closed this Jun 13, 2024
@gpmayorga gpmayorga merged commit 3b6a8c9 into main Jun 13, 2024
3 of 4 checks passed
@lemunozm
Copy link
Contributor

It seems like Frederik already fixed these issues in his PR and is merged automatically if the diff is 0 😆

@lemunozm
Copy link
Contributor

I can confirm that they have upgraded rustfmt to version 1.7.0-nightly without modifying the version number. Not sure if this is the usual way in nightly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants