-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to upgrade a Centrifuge parachain live #1884
Conversation
7a0f013
to
2b16239
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
- Coverage 47.66% 47.66% -0.01%
==========================================
Files 171 171
Lines 13233 13233
==========================================
- Hits 6308 6307 -1
- Misses 6925 6926 +1 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,853 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we needed to commit this, and yes, we need it: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the yarn.lock
to follow the runtime-upgrade-local
path. AFAIK, yarn locks are preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 4e38fda
We'll wait for @wischli to try this out and upgrade Demo, if it works I'd consider it ready |
Since we don't have an environment where we control the council keys, I'm going to remove the council motion from the automation but leave the govermnent proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpmayorga Thanks a lot for making our lives easier!
I removed the council related code paths because in the foreseeable future, we don't need to upgrade a non-local chain without sudo. If we need it at some point, we can migrate it over from the local script.
Later this year, I will refactor both scripts to use the same code paths as mentioned in the sync to decrease maintenance overhead. In the end, local and live chains can both use the same JS, only the bash script wrapper around it is different. For now, there are higher priorities and this script worked well for Dev and Demo.
Description
Upgrade a tesnet Centrifuge runtime by connecting to the node and uploading a new wasm using JS
Tested with sudo rights on development and demo.
In case we have control over the council on Altair or we have a parachain testnet with council and democracy in the future I left the code that allows for performing a RU using council keys