Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to upgrade a Centrifuge parachain live #1884

Merged
merged 12 commits into from
Jun 25, 2024
Merged

Script to upgrade a Centrifuge parachain live #1884

merged 12 commits into from
Jun 25, 2024

Conversation

gpmayorga
Copy link
Contributor

@gpmayorga gpmayorga commented Jun 23, 2024

Description

Upgrade a tesnet Centrifuge runtime by connecting to the node and uploading a new wasm using JS

Tested with sudo rights on development and demo.

In case we have control over the council on Altair or we have a parachain testnet with council and democracy in the future I left the code that allows for performing a RU using council keys

@gpmayorga gpmayorga changed the title Upgrade-script JS to upgrade a Centrifuge parachain live Jun 23, 2024
@gpmayorga gpmayorga changed the title JS to upgrade a Centrifuge parachain live Script to upgrade a Centrifuge parachain live Jun 23, 2024
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.66%. Comparing base (47384e9) to head (f7fe142).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
- Coverage   47.66%   47.66%   -0.01%     
==========================================
  Files         171      171              
  Lines       13233    13233              
==========================================
- Hits         6308     6307       -1     
- Misses       6925     6926       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,853 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we needed to commit this, and yes, we need it: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the yarn.lock to follow the runtime-upgrade-local path. AFAIK, yarn locks are preferred.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 4e38fda

@gpmayorga
Copy link
Contributor Author

We'll wait for @wischli to try this out and upgrade Demo, if it works I'd consider it ready

@gpmayorga
Copy link
Contributor Author

Since we don't have an environment where we control the council keys, I'm going to remove the council motion from the automation but leave the govermnent proposal

Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpmayorga Thanks a lot for making our lives easier!

I removed the council related code paths because in the foreseeable future, we don't need to upgrade a non-local chain without sudo. If we need it at some point, we can migrate it over from the local script.

Later this year, I will refactor both scripts to use the same code paths as mentioned in the sync to decrease maintenance overhead. In the end, local and live chains can both use the same JS, only the bash script wrapper around it is different. For now, there are higher priorities and this script worked well for Dev and Demo.

@wischli wischli merged commit de2886f into main Jun 25, 2024
12 checks passed
@wischli wischli deleted the upgrade-script branch June 25, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants