Release v0.13.0 #1898

wischli · 2024-07-05T07:55:51Z

Description

Removes migrations which are expected to have been executed
Bumps spec version to 1300
Updates deps to enable metadata hash check as recommended on Element
Updates srtool to latest version
Adds on-chain-release-build to srtool build opts
- Longterm we should switch to using the explicit github action: https://github.com/polkadot-fellows/runtimes/blob/bb52c327360d1098d3b3d36f4eafb40a74636e80/.github/workflows/release.yml#L59

Pipeline enhancements

Limit sanity_checks to 90m to avoid consuming minutes on stuck jobs
Modify wasm build to output srtool information
Upload artifacts when creating a release (wasm and json summary)
Upload json summary to GCP bucket too
Add a manual workflow to delete extra containers from GH registry (verified working)
Remove updating the release with the docker tag as appended comment (preferred to do manually)

Checklist:

I have added Rust doc comments to structs, enums, traits and functions
I have made corresponding changes to the documentation
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works

wischli · 2024-07-05T07:57:17Z

runtime/development/src/migrations.rs

 	// Initialize OpenGov Technical Committee with Alice
 	runtime_common::migrations::technical_comittee::InitMigration<crate::Runtime, InitialTcMembers>,
 	runtime_common::migrations::increase_storage_version::Migration<crate::Referenda, 0, 1>,


NOTE: Still needed because we haven't upgraded Dev and Demo to 1200.

lemunozm

LGTM

lemunozm · 2024-07-05T08:02:04Z

Cargo.toml

@@ -53,7 +53,7 @@ license = "LGPL-3.0"
 homepage = "https://centrifuge.io/"
 repository = "https://github.com/centrifuge/centrifuge-chain"
 documentation = "https://reference.centrifuge.io/centrifuge_chain/index.html"
-version = "0.12.0"
+version = "0.13.0"


Why a major version instead of 0.12.1?

That's something I battled with internally myself. I thought this would be cleaner because v0.12.0 was related to enabling OpenGov on Altair.

Since this enables the metadata hash check, I think it deserves its major version. For similar releases in the future, I will take the minor version approach then since you seem to prefer that as well.

mustermeiszer

That was fast! LGTM!

wischli · 2024-07-10T16:02:39Z

@lemunozm Seems like WASM building succeeds now. Can you please to the nth re-approval so we can get this merged finally? Thanks for the patience! And thanks @gpmayorga for putting so much energy in improving our WASM CI.

lemunozm

Let's merge this! Thanks for your work on this 🚀

lemunozm · 2024-07-10T16:37:49Z

.github/workflows/build-docker.yml

+      # - name: Update GitHub release
+      #   if: github.event_name == 'release' && github.event.action == 'released' && matrix.target == 'release'
+      #   uses: softprops/action-gh-release@v1
+      #   with:
+      #     append_body: true
+      #     body: |
+      #       **Docker tags (${{ env.NOW }}):**
+      #          ${{ steps.meta.outputs.tags }}


Tech-debt: should it be maintained in the repo or removed? @gpmayorga

Good catch. IMO, we can remove this!

wischli · 2024-07-11T06:59:52Z

@gpmayorga We need your approval as CI code owner

fix: adapt passthrough router fix: docs and hash chore: rm unused test Release v0.11.3 (#1886) * Switch to full wasm execution * feat: use correct encoded size. * fix: lint * refactor: reduce dev session duration from 6h to 2min * chore: update centrifuge weights * chore: update dev weights * chore: update altair weights * chore: update frame_system weights * fmt * fix: re-enable frame_system benches * chore: bump spec version * fmt: revert using latest nightly * v0.11.3-rc1: revert checkmetadata ext * feat: `CheckMetadataHash` extension (#1865) * set dependency versions * upgrade libs/* * upgrade pallet-anchors * upgrade pallet-fees * upgrade pallet-bridge * migrate simple pallets * migrate pallet-order-book * migrated collator-allowlist & swaps * upgrade rewards * upgraded pallet-mux * upgrade transfer-allowlist * fix hold reason in restricted tokens * simplify set_balance removing the holding part * upgrade restricted-xtokens * upgrade some pallets * upgrade pallet-ethereum-transaction * upgrade pallet-loans * upgrade pool-system * upgrade pool-fees * upgrade pool-registry * upgrade liquidity-pools stuffs * avoid duplicated polkadot-sdk repos * minor fixes * upgraded runtime-common * CfgLocation to RestrictedTransferLocation * restricted tokens with NativeIndex for native fungibles * rename dependency * upgraded development-runtime * fix partially benchmarks * fix benchmarks * overpass xcmp-queue integrity tests * minor coments * upgrade altair & centrifuge * remove some benchmarking pallets that are not needed * fix runtime upgrades * upgrade integration-test proc * upgrade integration-tests framework * upgraded all tests except liquidity pools * 99% upgraded liquidity-pools tests * fix lookup * cargo fmt * taplo fmt * using nightly cargo in CI * restore set_balance as it was * allow nightly support in CI * use restricted_tokens again to fetch from investement portfolio * Install rust-src for docs * fix tests * remove unused restricted tokens * fix block rewards * fix WrongWitness for some tests in IT * fix liquidity-pools * minor fixes * fix clippy * remove unneeded tests * feat: Update client to Polkadot v1.7.2 (#1844) * wip: update client * chore: update crate versions * chore: update anchor rpc api * chore: remove rewards, pools rpc * chore: compile with development runtime * fix: client for all runtimes * fix: build spec * feat: update relay docker images * fix: apply deprecation of export genesis state to scripts * fmt: taplo * refactor: use xcm v4 sugar * fix: revert tmp change in local para run * refactor: simplify xcm v4 locations in chain spec * cargo fmt * fix clippy * feat: Polkadot v1.7.2 migrations (#1849) * feat: add hold reason migration * feat: centrifuge migrations * feat: altair migrations * feat: dev + demo migrations * fix: clippy * fix: build * fmt: fix using nightly * last William iteration review * increase passed blocks * use rococo instead of polkadot-test-runtime * fix tests * remove line * dirty fix to fix Hrmp test issue * use default weights for treasury * remove getrandom unused dep * upgrade to last polkadot-sdk version * feat: `CheckMetadataHash` extension * fix it (#1866) * fmt: taplo * refactor: signed ext order * fix: signed ext order for ITs * IT: more support for router tests (#1885) * move routers to its own module * remove outdated markers * for all runtimes * remove previous tests * minor fixes * v0.11.2 rc * panic if event is not found in the expected blocks (#1880) * fix: ci * remove generic module (#1887) * revert check metadata hash disable * fix: disable metadata hash check for integration tests --------- Co-authored-by: lemunozm <[email protected]> --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Frederik Gartenmeister <[email protected]> Co-authored-by: lemunozm <[email protected]> Refactor: Decoupling routers from gateway (#1891) * decoupling routers from gateway. Use Vec<u8> * gateway adapted * fix imports * move test msg to cfg-traits * fix imports feat: Open Gov for Development and Altair Runtimes (#1828) * chore: add OpenGov pallets to root toml * feat: add OpenGov tracks to runtime common * feat: add technical committee migration tc: fix clippy * refactor: move origins from primitives to common common: fix typo common: fix test after HalfOfCouncil refactor * feat: add OpenGov to Development fix: complete Development OpenGov development: finalize opengov development: add proxy calls development: overwrite missing origins dev: fix treasury spender dev: remove crowdloan pallets dev: taplo fmt * feat: add OpenGov to Altair fix: complete Altair OpenGov fix: add missing technical fellowship weights Altair altair: finalize opengov altair: rename track tests altair: gather imports altair: remove crowdloan pallets altair: taplo fmt * feat: add OpenGov to Centrifuge chain fix: centrifuge toml chore: minor centrifuge chain improvements refactor: Centrifuge OpenGov centrifuge: finalize opengov centrifuge: fix cargo tml cfg: fix clippy test * Revert "feat: add OpenGov to Centrifuge chain" This reverts commit 4d78c10. * fix: clippy * tests: fix CouncilCollective import path * fix: technical committee migrations * altair: configure tc migration (incomplete) * dev: configure tc migration * chore: cleanup altair dep diff * chore: remove unused getrandom crate from runtimes * chore: add missing Altair TC members * refactor: move to_ppm and to_percent to utils * Merge remote-tracking branch 'origin/main' into feat/open-gov-2 * fix: issues after rebasing * fmt * fix: imports * feat: v0.12.0 for altair RU Altair: release v0.12.0 (#1896) * fix: altair chain spec * chore: update gov2 weights * chore: update dev OpenGov weights * fix: weight declaration Fix RustDocs deployment & codecov patch checks (#1870) * Fix deploy docs * Make patch checks also informational (not fail) LP Message with custom data format for serialization/deserialization (#1889) * test compiling * fix Domain serialization * fix issues * some reorganizations * using bincode 2 with non-std support * use custom trait * tests passing for lp * remove ENCODED_MSG constant * fix runtimes compilation * cargo fmt & taplo fmt * cargo clippy * minor change * add custom serializer passing all tests * no_std support * minor renames * cargo fmt * cargo clippy * minor comment change * cargo fmt extra Succeed when patch codecov fails (#1900) Liquidity pools: Add UTs to for `update_token_price()` (#1890) * add token price UTs * update IT * fix tests compilation remove some unused code investment-related (#1902) Release v0.13.0 (#1898) * chore: update deps to enable metadata hash check * chore: update srtool + add on-chain-release-build opts * chore: bump spec versions + cleanup migrations * fmt: taplo * ci: fix srtool fmt * ci: apply proper CLI * attempt2 to enable on-chain-release-build * change srtool build for chevdor/strool-actions action * desperate attempts to get it working * override workdir * Try to set permissions wide open before running docker * add RUST_BACKTRACE * revert to our GHA manual process & add enhancements * fix package name * Output information about srtool * Revert "desperate attempts to get it working" This reverts commit a882fd9. * fix: some scripts * fix bad colon on echo command * Fix missing colon and remove docker publish release * upload wasm to release * fix issue with gchr tags * more semicolon issues * unique name for delete untagged * fix delete_untagged * move delete_untagged under workflows * move delete untagged to manual runs * review bash syntax for wasm build * recover cache and limit sanity check build time --------- Co-authored-by: Guillermo Perez <[email protected]> cargo update (#1904) add uts (#1905) IT: Support `#ignore = reason` for `test_runtimes` macro (#1908) * support #ignore = reason for test_runtimes macro * fix clippy ci: disable checks for drafts (#1913) LP: Unitary testing for add_currency (#1912) * port add-currency tests into uts * remove LiquidityPoolsWrappedToken struct * remove unused code * fix compilation issues * fix clippy * fix clippy feat: adatpt to latest version LP: Unitary testing for all pending extrinsics (#1916) * allow and disallow currency tests * schedule_upgrade cancel_upgrade and update_tranche_token_metadata Feat: Adapt proxy settings (#1922) * feat: adapt proxy settings * fix: match pattern Small CI improvements (#1924) LP: Unitary testing for inbound messages (#1927) * tests inbound messages * some cleanings * some adjustements fix: array size fix: clippy + fmt fix: update blake hash fix: compilation Refactor: Transform `TrancheCurrency` type in a tuple (#1926) * remove TrancheCurrency type * fix benchmarks * fix clippy fix: std import KeccakHasher

wischli added 3 commits July 5, 2024 09:49

chore: update deps to enable metadata hash check

dd23213

chore: update srtool + add on-chain-release-build opts

0a26688

chore: bump spec versions + cleanup migrations

3da4e2e

wischli added the I9-release A specific release. label Jul 5, 2024

wischli had a problem deploying to production July 5, 2024 07:55 — with GitHub Actions Failure

wischli had a problem deploying to production July 5, 2024 07:55 — with GitHub Actions Error

fmt: taplo

595b275

wischli had a problem deploying to production July 5, 2024 07:56 — with GitHub Actions Error

wischli had a problem deploying to production July 5, 2024 07:56 — with GitHub Actions Failure

wischli commented Jul 5, 2024

View reviewed changes

lemunozm previously approved these changes Jul 5, 2024

View reviewed changes

wischli dismissed lemunozm’s stale review via e4780e7 July 5, 2024 08:05

wischli had a problem deploying to production July 5, 2024 08:06 — with GitHub Actions Error

ci: fix srtool fmt

d90644b

wischli force-pushed the release-v0.13.0 branch from e4780e7 to d90644b Compare July 5, 2024 08:06

wischli had a problem deploying to production July 5, 2024 08:07 — with GitHub Actions Failure

wischli had a problem deploying to production July 5, 2024 08:07 — with GitHub Actions Error

wischli had a problem deploying to production July 5, 2024 08:07 — with GitHub Actions Failure

ci: apply proper CLI

4cb3180

wischli temporarily deployed to production July 5, 2024 08:11 — with GitHub Actions Inactive

wischli self-assigned this Jul 5, 2024

mustermeiszer previously approved these changes Jul 5, 2024

View reviewed changes

wischli temporarily deployed to production July 5, 2024 10:06 — with GitHub Actions Inactive

gpmayorga had a problem deploying to production July 9, 2024 10:27 — with GitHub Actions Error

move delete untagged to manual runs

acc6ff5

gpmayorga had a problem deploying to production July 9, 2024 10:35 — with GitHub Actions Error

gpmayorga had a problem deploying to production July 9, 2024 10:35 — with GitHub Actions Failure

gpmayorga had a problem deploying to production July 9, 2024 10:35 — with GitHub Actions Error

review bash syntax for wasm build

c4785b1

gpmayorga had a problem deploying to production July 9, 2024 14:39 — with GitHub Actions Error

recover cache and limit sanity check build time

209167e

gpmayorga had a problem deploying to production July 9, 2024 14:53 — with GitHub Actions Error

gpmayorga had a problem deploying to production July 9, 2024 14:53 — with GitHub Actions Failure

gpmayorga had a problem deploying to production July 9, 2024 14:53 — with GitHub Actions Error

lemunozm mentioned this pull request Jul 10, 2024

Update dependencies #1904

Merged

wischli marked this pull request as ready for review July 10, 2024 14:27

wischli requested a review from gpmayorga as a code owner July 10, 2024 14:27

gpmayorga temporarily deployed to production July 10, 2024 14:27 — with GitHub Actions Inactive

wischli enabled auto-merge (squash) July 10, 2024 16:01

wischli requested a review from lemunozm July 10, 2024 16:01

lemunozm approved these changes Jul 10, 2024

View reviewed changes

wischli mentioned this pull request Jul 11, 2024

LP: Add Unitary Tests for update_member() #1905

Merged

gpmayorga approved these changes Jul 11, 2024

View reviewed changes

wischli merged commit ee401ff into main Jul 11, 2024
15 checks passed

gpmayorga deleted the release-v0.13.0 branch July 11, 2024 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v0.13.0 #1898

Release v0.13.0 #1898

wischli commented Jul 5, 2024 •

edited by gpmayorga

Loading

wischli Jul 5, 2024

lemunozm left a comment

lemunozm Jul 5, 2024

wischli Jul 5, 2024

mustermeiszer left a comment

wischli commented Jul 10, 2024

lemunozm left a comment

lemunozm Jul 10, 2024 •

edited

Loading

wischli Jul 11, 2024

wischli commented Jul 11, 2024

Release v0.13.0 #1898

Release v0.13.0 #1898

Conversation

wischli commented Jul 5, 2024 • edited by gpmayorga Loading

Description

Checklist:

wischli Jul 5, 2024

Choose a reason for hiding this comment

lemunozm left a comment

Choose a reason for hiding this comment

lemunozm Jul 5, 2024

Choose a reason for hiding this comment

wischli Jul 5, 2024

Choose a reason for hiding this comment

mustermeiszer left a comment

Choose a reason for hiding this comment

wischli commented Jul 10, 2024

lemunozm left a comment

Choose a reason for hiding this comment

lemunozm Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

wischli Jul 11, 2024

Choose a reason for hiding this comment

wischli commented Jul 11, 2024

wischli commented Jul 5, 2024 •

edited by gpmayorga

Loading

lemunozm Jul 10, 2024 •

edited

Loading