Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add remark call to borrow proxy #1929

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

mustermeiszer
Copy link
Collaborator

Description

Needed for apps

Changes and Descriptions

  • Adds pallet_remarks::Call::remark to the allowed calls for ProxyType::Borrow

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@mustermeiszer mustermeiszer requested a review from wischli July 26, 2024 09:30
@mustermeiszer mustermeiszer enabled auto-merge (squash) July 26, 2024 11:10
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.92%. Comparing base (f5ce924) to head (aace4d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   47.95%   47.92%   -0.03%     
==========================================
  Files         181      181              
  Lines       13159    13159              
==========================================
- Hits         6310     6307       -3     
- Misses       6849     6852       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mustermeiszer mustermeiszer merged commit f647a49 into main Jul 26, 2024
11 checks passed
@wischli wischli deleted the fix/borrow-proxy-remark branch July 26, 2024 12:12
gpmayorga pushed a commit that referenced this pull request Jul 29, 2024
@wischli wischli mentioned this pull request Jul 30, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants