Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

altair: Update benchmark computed in the cloud #714

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

NunoAlexandre
Copy link
Contributor

All the changes are automated output from running run_benchmarks in our cloud instance

@@ -32,17 +32,17 @@ use sp_std::marker::PhantomData;
pub struct SubstrateWeight<T>(PhantomData<T>);
impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn add() -> Weight {
(32_000_000 as Weight)
(79_141_000 as Weight)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the previous revision of this file was a copy of pallets/nft-sales/src/weights.rs, obtained by running the benchmarks on my machine. Thus the significant difference comparing to the value now computed in the cloud.

@NunoAlexandre NunoAlexandre marked this pull request as ready for review March 21, 2022 12:34
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikiquantum mikiquantum merged commit 091e3e3 into parachain Mar 21, 2022
@mikiquantum mikiquantum deleted the altair/benchmarks branch March 21, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants