Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce list-based mint method parameters #6

Closed
pstehlik opened this issue Sep 24, 2018 · 0 comments
Closed

Introduce list-based mint method parameters #6

pstehlik opened this issue Sep 24, 2018 · 0 comments
Assignees

Comments

@pstehlik
Copy link
Contributor

pstehlik commented Sep 24, 2018

Support arbitrary number or proofs being submitted when minting an NFT.
Currently, the mint method requires each proof in its own set of parameters.

  • Create a mint method that supports arbirtraty number of proofs being provided
    -- This allows to have a consistent ABI defition for any ERC721 registry - easier integration with clients
    Pseudo code
function mintMerklePlainText (
    address _to, 
    uint256 _tokenId, 
    bytes32 _documentId, 
    bytes32 _merkleRoot, 
    proofs [
      {
        bytes32[] _proof, 
        string _leafName,
        string _leafValue,
        bytes32 _leafSalt 
      } ,
      {
        bytes32[] _proof, 
        string _leafName,
        string _leafValue,
        bytes32 _leafSalt 
      } ,
      {
        bytes32[] _proof, 
        string _leafName,
        string _leafValue,
        bytes32 _leafSalt 
      } ,
....
    ]
  ) 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants