Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment obligations v2 #45

Closed
wants to merge 8 commits into from
Closed

Payment obligations v2 #45

wants to merge 8 commits into from

Conversation

rdinicut
Copy link
Contributor

@rdinicut rdinicut commented Oct 4, 2018

Managed to implement the payment obligation contract with an array of structs. This requires the latest version of web3: 1.0.0-beta.36. and I am using 2 version of web3 in truffle. This is also valid for metamask as it does not support web3 1.0.
We need to check that the AbiEncoder from abigen supports this.

This PR includes multiple issues from the backlog:

@rdinicut rdinicut requested review from lucasvo and pstehlik October 4, 2018 08:59
@xmxanuel
Copy link
Member

xmxanuel commented Oct 5, 2018

I tried to generate the go-bindings with abigen.
(I used the latest version of abigen from the go-ethereum master branch.)

It seems like it is currently not supported to return an array of structs.

command is used

➜  centrifuge-ethereum-contracts git:(51aba7c) ✗ abigen --abi PaymentObligation.abi --pkg nft --type PaymentObligation --out payment_obligation_ethereum.go
Failed to generate ABI binding: unsupported arg type: tuple

error message

Failed to generate ABI binding: unsupported arg type: tuple

Related issues on go-ethereum

ethereum/go-ethereum#17152
ethereum/go-ethereum#17642

@rdinicut rdinicut closed this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants