add markdownlint make targets #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obnoxxx
force-pushed
the
markdownlint
branch
3 times, most recently
from
c3b571b to
3f4abf4
Compare
Madhu-1
reviewed
Jan 15, 2025
obnoxxx
force-pushed
the
markdownlint
branch
3 times, most recently
from
244732a to
ec344ef
Compare
Madhu-1
reviewed
Jan 15, 2025
obnoxxx
force-pushed
the
markdownlint
branch
2 times, most recently
from
99e9ef2 to
7bc6bc1
Compare
|
Job is not running https://github.com/ceph/ceph-csi-operator/actions/runs/12785427589 |
This is so that markdownlint can conveniently be run locally in developer environments. Signed-off-by: Michael Adam <[email protected]>
Signed-off-by: Michael Adam <[email protected]>
Also fixed a lint error in an issue template Signed-off-by: Michael Adam <[email protected]>
Madhu-1
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR adds make targets
markdownlintandmarkdownlint-fixto allow developers to conveniently run markdownlint locally.The
lintci workflow is changed to use the make target instead of the github action.Is there anything that requires special attention
This PR is based on and depends on PR #195
Is the change backward compatible?
yes
Are there concerns around backward compatibility?
no
Related issues
Fixes: #159
Future concerns
none
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.