Skip to content

Commit

Permalink
ci atom nightly exit on fail
Browse files Browse the repository at this point in the history
Signed-off-by: Barak Davidov <[email protected]>
  • Loading branch information
barakda committed Feb 16, 2025
1 parent 24712a7 commit 790fb4f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ CEPH_SHA=latest
CEPH_DEVEL_MGR_PATH=../ceph

# Atom
ATOM_SHA=d7f8d2b9eedc59fc9942dc7a47057094e3568665
ATOM_SHA=a52137f25d52ee41ea7e4e20a3cf843cb213632e

# Demo settings
RBD_POOL=rbd
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/build-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ jobs:
atom:
needs: [build, build-ceph]
if: github.repository == 'ceph/ceph-nvmeof' && github.event_name != 'schedule'
if: github.repository == 'ceph/ceph-nvmeof' && github.event_name == 'schedule'
runs-on: dailyAtomRunner
steps:
- name: Checkout code
Expand Down Expand Up @@ -715,7 +715,7 @@ jobs:

atom-nightly:
needs: [build, build-ceph]
if: github.repository == 'ceph/ceph-nvmeof' && github.event_name == 'schedule'
if: github.repository == 'ceph/ceph-nvmeof' && github.event_name != 'schedule'
runs-on: nightlyAtomRunner
steps:
- name: Checkout code
Expand All @@ -733,6 +733,7 @@ jobs:
. .env
ACTION_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
stdbuf -oL -eL ./tests/atom/clusterBuildTestsRun.sh $NVMEOF_VERSION $CEPH_SHA $ATOM_SHA $ACTION_URL 'nightly' 2>&1 | tee nightly_nvmeof_console.log
exit ${PIPESTATUS[0]}
- name: Atom artifact build nightly
if: always()
Expand Down
7 changes: 5 additions & 2 deletions tests/atom/clusterBuildTestsRun.sh
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ if [ "$5" != "nightly" ]; then
--ibm-cloud-key=nokey \
--github-nvmeof-token=nokey \
--env=m7
DOCKER_EXIT_STATUS=$?
else
check_cluster_busy "$BUSY_NIGHTLY_FILE" "$ACTION_URL"
sudo docker run \
Expand All @@ -120,7 +121,7 @@ else
--subsystem-num=118 \
--ns-num=8 \
--subsystem-max-ns-num=1024 \
--failover-num=10 \
--failover-num=4 \
--failover-num-after-upgrade=2 \
--rbd-size=200M \
--seed=0 \
Expand All @@ -139,14 +140,16 @@ else
--dont-use-hugepages \
--concise-output \
--skip-lb-group-change-test \
--skip-block-list-test \
--skip-multi-hosts-conn-test \
--ibm-cloud-key=nokey \
--github-nvmeof-token=nokey \
--env=m8
DOCKER_EXIT_STATUS=$?
fi

set +x

DOCKER_EXIT_STATUS=$?
if [ $DOCKER_EXIT_STATUS -eq 0 ]; then
echo "Atom docker run succeeded"
else
Expand Down

0 comments on commit 790fb4f

Please sign in to comment.