Add application/json to gzip types, mjs MIME type update
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamduncan
changed the title
application/json to gzip typesapplication/json to gzip types, mjs MIME type update
|
From this comment:
I feel like I remember that from adjusting this setting on another one of my public sites. docs.ceph.com maybe? Anyway, I just checked out this branch and pushed the changes to nginx. If it looks right to you (i.e., no errors), I'm fine with it. |
Cool, thanks for following up @djgalloway. Yep, sounds like there's been some ambiguity around this MIME type, but happy to go with the spec (and can't see it throwing up any issues with JS sources). Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #104, it would be great if we could gzip
application/jsonfiles. We'll have a few static JSON assets (search indices, etc.) which would benefit a lot from compression.@djgalloway is this fair game/all we need to include?
Related, we currently have
text/javascriptincluded in our gzip types, but we set the.mjsMIME type toapplication/javascript. Based on a little digging, I've also updated this totext/javascriptto ensure they're gzipped as intended. Shout if this isn't in line with your expectations.