-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cephio/top-level: remove marketing copy #223
cephio/top-level: remove marketing copy #223
Conversation
@@ -13,7 +13,7 @@ <h1 class="h1 visually-hidden">Ceph.io {{ title }}</h1> | |||
<div class="wrapper"> | |||
<div class="color-white max-w-192 relative z-1"> | |||
<h2 class="h1 mb-8">The Future of Storage<sup>™</sup></h2> | |||
<p class="mb-10 standout">Ceph is an open source distributed storage system designed to evolve with data.</p> | |||
<p class="mb-10 standout">Ceph is an open-source, distributed storage system.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ceph is an open source distributed storage system designed to scale with your data
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made this change.
src/en/index.html
Outdated
container native, Ceph is applicable to wide range of use cases. | ||
Use Ceph to transform your storage infrastructure. Ceph provides a unified | ||
storage service with object, block, and file interfaces from a single | ||
cluster built from commodity hardware components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -36,7 +36,7 @@ <h2 class="h2">Reliable and scalable storage designed for any organization</h2> | |||
</div> | |||
<div> | |||
<h2 class="h2">Ceph for developers</h2> | |||
<p class="p mb-8">Setup, deploy, manage, code and contribute to Ceph.</p> | |||
<p class="p mb-8">Deploy Ceph now. Use the links below to acquire Ceph and deploy a Ceph cluster.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, I think we should
- add a separate block above that says "Deploy or manage a Ceph cluster" and has the 'getting started' and 'documentation' links
- remove the getting started link from this block, and change text to "Study, modify, and contribute to Ceph" or similar and keeps the code and contribute links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made these alterations.
However, as foretold by (my own) prophecy, I messed up the formatting of the buttons. Here's where Pete comes to the rescue.
Pete, can you make sense of the nonsense of buttons I have foisted upon you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pete-Robelou see supra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, all good. I'll sort it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zdover23 @liewegas I've updated the layout with a new section, capitalised the text and amended a few of the links.
Deploy or manage a Ceph cluster
- Deploy or manage a Ceph cluster >
/users/
- Getting started >
/users/getting-started/
- Documentation >
/users/documentation/
Ceph for developers
- Study, modify and contribute >
/users/getting-started/
Should this link to/developers/
? - Code >
/developers/code/
- Contribute >
/developers/contribute/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, /developers
I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated Study, modify and contribute to /developers/
This PR rewrites placeholder marketing copy. Signed-off-by: Zac Dover <[email protected]>
043d061
to
7e17a4c
Compare
src/en/index.html
Outdated
</p> | ||
</section> | ||
|
||
<section class="bg-grey-300 section section--full"> | ||
<div class="wrapper"> | ||
<div> | ||
<h2 class="h2">Deploy or manage a Ceph cluster</h2> | ||
<p class="p mb-8">deploy ceph now. use the links below to acquire ceph and deploy a ceph cluster.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does capitalization matter here or does the style take care of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Captilization here matters, yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll resolve this when I update the layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's weird. I suspect that I pressed "gu" after selecting all the text in the tags with "vit" in vim. If that's all Darmok and Jilad at Tenagra to you, just know that this is my fault and that I caused it by using vim.
- Capitalisation of text - New Deploy or manage Ceph cluster section - Updated hrefs to use locale
Thanks all, team effort. @liewegas if you're please able to sign-off on this PR, and we can get it merged? This should be our last content amend required prior to merging to |
This PR rewrites placeholder marketing copy.
Signed-off-by: Zac Dover [email protected]