Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephio/top-level: remove marketing copy #223

Merged
merged 5 commits into from
Jun 23, 2021

Conversation

zdover23
Copy link
Contributor

This PR rewrites placeholder marketing copy.

Signed-off-by: Zac Dover [email protected]

@zdover23 zdover23 requested a review from liewegas June 22, 2021 15:31
@adamduncan adamduncan requested a review from Pete-Robelou June 22, 2021 15:36
@@ -13,7 +13,7 @@ <h1 class="h1 visually-hidden">Ceph.io {{ title }}</h1>
<div class="wrapper">
<div class="color-white max-w-192 relative z-1">
<h2 class="h1 mb-8">The Future of Storage<sup>™</sup></h2>
<p class="mb-10 standout">Ceph is an open source distributed storage system designed to evolve with&nbsp;data.</p>
<p class="mb-10 standout">Ceph is an open-source, distributed storage system.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ceph is an open source distributed storage system designed to scale with your data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made this change.

container native, Ceph is applicable to wide range of use cases.
Use Ceph to transform your storage infrastructure. Ceph provides a unified
storage service with object, block, and file interfaces from a single
cluster built from commodity hardware components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -36,7 +36,7 @@ <h2 class="h2">Reliable and scalable storage designed for any organization</h2>
</div>
<div>
<h2 class="h2">Ceph for developers</h2>
<p class="p mb-8">Setup, deploy, manage, code and contribute to Ceph.</p>
<p class="p mb-8">Deploy Ceph now. Use the links below to acquire Ceph and deploy a Ceph cluster.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, I think we should

  1. add a separate block above that says "Deploy or manage a Ceph cluster" and has the 'getting started' and 'documentation' links
  2. remove the getting started link from this block, and change text to "Study, modify, and contribute to Ceph" or similar and keeps the code and contribute links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made these alterations.

However, as foretold by (my own) prophecy, I messed up the formatting of the buttons. Here's where Pete comes to the rescue.

Pete, can you make sense of the nonsense of buttons I have foisted upon you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pete-Robelou see supra

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, all good. I'll sort it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zdover23 @liewegas I've updated the layout with a new section, capitalised the text and amended a few of the links.

Deploy or manage a Ceph cluster

  • Deploy or manage a Ceph cluster > /users/
  • Getting started > /users/getting-started/
  • Documentation > /users/documentation/

Ceph for developers

  • Study, modify and contribute > /users/getting-started/ Should this link to /developers/ ?
  • Code > /developers/code/
  • Contribute > /developers/contribute/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, /developers I think

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated Study, modify and contribute to /developers/

This PR rewrites placeholder marketing copy.

Signed-off-by: Zac Dover <[email protected]>
@zdover23 zdover23 force-pushed the wip-doc-front-page-rewrite-2021-06-22 branch from 043d061 to 7e17a4c Compare June 22, 2021 16:10
@zdover23 zdover23 requested a review from liewegas June 22, 2021 16:11
</p>
</section>

<section class="bg-grey-300 section section--full">
<div class="wrapper">
<div>
<h2 class="h2">Deploy or manage a Ceph cluster</h2>
<p class="p mb-8">deploy ceph now. use the links below to acquire ceph and deploy a ceph cluster.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does capitalization matter here or does the style take care of it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captilization here matters, yep

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll resolve this when I update the layout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's weird. I suspect that I pressed "gu" after selecting all the text in the tags with "vit" in vim. If that's all Darmok and Jilad at Tenagra to you, just know that this is my fault and that I caused it by using vim.

- Capitalisation of text
- New Deploy or manage Ceph cluster section
- Updated hrefs to use locale
@zdover23 zdover23 requested a review from liewegas June 22, 2021 17:51
@adamduncan
Copy link
Collaborator

adamduncan commented Jun 23, 2021

Thanks all, team effort.

@liewegas if you're please able to sign-off on this PR, and we can get it merged? This should be our last content amend required prior to merging to main 👍

@liewegas liewegas merged commit 19b1f25 into ceph:develop Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants