-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/k8sevents: pin the kubernetes version to 11.0.0 #43668
mgr/k8sevents: pin the kubernetes version to 11.0.0 #43668
Conversation
c84509e
to
d1d9d64
Compare
The first run made the tests pass although some other tests failed. (https://jenkins.ceph.com/job/ceph-pull-requests/84498/console)
|
@jmolmo @sebastian-philipp Can you take a look at this fix? See the original error. |
we have to pin the version to the one shipped by our container image base (centos 8.?) Everything is not going to work. |
Yes, that should be the correct way rather than expecting these kinds of errors in every API change. I am not sure how to pin the version or which version we were using before. @sebastian-philipp |
Also i am not seeing the error happening on pacific, so it is using on older api. |
should be |
@sebastian-philipp I think we just need to pin the kubernetes version over here right? Probably to not the latest one? https://github.com/ceph/ceph/blob/pacific/src/pybind/mgr/requirements.txt#L3 |
I'd pin it to 11.0.0 if that exist in pypi |
Fixes: https://tracker.ceph.com/issues/53044 Signed-off-by: Nizamudeen A <[email protected]>
d1d9d64
to
f54ea99
Compare
It exists, and pinned it. Updated the PR. |
Thank you @nizamial09!! I was looking into this last night and couldn't figure out the cause. This is very helpful. |
You're welcome! @ljflores |
There's an API change (kubernetes-client/python@c04e2f6#diff-64d3d8da58fddca2ed360257976a6ab3e28fdc4805e3480d99af857ce914dc20R27-R32) happened during last night (morning depending on your timezone) which updated the
V1Events
toCoreV1Events
. That causes amake check failure and this commit intends to fix it.
kubernetes-client API Change PR: kubernetes-client/python#1597
Fixes: https://tracker.ceph.com/issues/53044
Signed-off-by: Nizamudeen A [email protected]
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox