Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use golangci-lint as linter #599

Closed
wants to merge 3 commits into from
Closed

Conversation

ansiwen
Copy link
Collaborator

@ansiwen ansiwen commented Oct 13, 2021

Let's play around with golangci-lint, which also can start revive and has a "new" mode.

@ansiwen ansiwen force-pushed the pr/ansiwen/golangci-lint branch from 22f4963 to bba7d1c Compare October 15, 2021 10:04
@phlogistonjohn
Copy link
Collaborator

Hi @ansiwen do you think you'll resume working on this PR? Thanks!

@ansiwen
Copy link
Collaborator Author

ansiwen commented Feb 3, 2022

@phlogistonjohn I very much hope so, yes. ;-)

@ansiwen ansiwen added the no-API This PR does not include any changes to the public API of a go-ceph package label Feb 15, 2022
@mergify
Copy link

mergify bot commented Apr 12, 2022

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@ansiwen ansiwen force-pushed the pr/ansiwen/golangci-lint branch from a1aa7b2 to b339c8c Compare July 28, 2022 09:08
@ansiwen
Copy link
Collaborator Author

ansiwen commented Jul 29, 2022

We can't use golang-ci until golangci/golangci-lint#2910 is fixed.

@mergify
Copy link

mergify bot commented Aug 2, 2022

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@ansiwen ansiwen force-pushed the pr/ansiwen/golangci-lint branch 8 times, most recently from 8e177f2 to 8097106 Compare August 2, 2022 11:50
@mergify
Copy link

mergify bot commented Aug 2, 2022

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@ansiwen ansiwen force-pushed the pr/ansiwen/golangci-lint branch 12 times, most recently from ac767da to 7c43a49 Compare August 4, 2022 13:42
@ansiwen ansiwen force-pushed the pr/ansiwen/golangci-lint branch 10 times, most recently from 02ae860 to c421cfa Compare August 4, 2022 16:53
@mergify
Copy link

mergify bot commented Aug 12, 2022

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

1 similar comment
@mergify
Copy link

mergify bot commented Sep 27, 2022

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@ansiwen ansiwen force-pushed the pr/ansiwen/golangci-lint branch 5 times, most recently from 30adea1 to 2fd1e11 Compare November 30, 2022 17:20
@ansiwen ansiwen force-pushed the pr/ansiwen/golangci-lint branch from 2fd1e11 to bc9122b Compare November 30, 2022 17:22
@mergify
Copy link

mergify bot commented Aug 2, 2023

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This Pull Request has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remember, a closed PR can always be reopened. Thank you for your contribution.

@github-actions github-actions bot added the Stale label Oct 2, 2023
@github-actions
Copy link

This Pull Request has been automatically closed due to inactivity. In the future, if you resume working on this again, the PR can be reopened. Additionally, if you are proposing a feature or fix that you think someone else could take up - please say so - and if there is no existing issue already, file an issue for the topic. Thank you for your contribution.

@github-actions github-actions bot closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge no-API This PR does not include any changes to the public API of a go-ceph package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants