Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill: Don't unlock nodes if killing procs fails #1899

Merged
merged 1 commit into from
Nov 29, 2023
Merged

kill: Don't unlock nodes if killing procs fails #1899

merged 1 commit into from
Nov 29, 2023

Conversation

zmc
Copy link
Member

@zmc zmc commented Nov 10, 2023

... so that we don't unlock nodes while their jobs are running.

@zmc zmc marked this pull request as ready for review November 13, 2023 19:19
@zmc zmc requested a review from kamoltat November 14, 2023 19:46
kamoltat
kamoltat previously approved these changes Nov 22, 2023
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment that I'm just curious about.

teuthology/kill.py Outdated Show resolved Hide resolved
... so that we don't unlock nodes while their jobs are running.

Signed-off-by: Zack Cerza <[email protected]>
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmc
Looks good! I'll let you merge this, so you have control of the timing of the changes in prod.

@zmc zmc merged commit f2de108 into main Nov 29, 2023
9 checks passed
@zmc zmc deleted the kill-proc-perms branch November 29, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants