Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd units for exporter and dispatcher #1900

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Add systemd units for exporter and dispatcher #1900

merged 1 commit into from
Dec 20, 2023

Conversation

zmc
Copy link
Member

@zmc zmc commented Nov 15, 2023

These are copies of what is currently in use in sepia.

These are copies of what is currently in use in sepia.

Signed-off-by: Zack Cerza <[email protected]>
@zmc zmc requested a review from dmick November 15, 2023 20:04
@zmc zmc marked this pull request as ready for review November 15, 2023 20:07
[Service]
Type=simple
User=teuthworker
ExecStart=/home/teuthworker/src/git.ceph.com_git_teuthology_main/virtualenv/bin/python3.8 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why this refers to git.ceph.com, but not GitHub?
Also maybe there must be a parameter according to ansible or other scripts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git.ceph.com is the local mirror that virtually everything in teuthology uses, so it's the one most likely to be present and current. don't know what parameters you mean exactly, but there is the 'instance' parameter so that one starts teuthology-dispatcher@smithi, for instance

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files have several hardcoded elements that someone in a different setting will want to change; I'm not sure if there is a reasonable way to parametrize all of them, but I think it's fine to ship what are effectively templates that users can modify to suit their needs.

@dmick
Copy link
Member

dmick commented Dec 20, 2023

I think we're using these now, which is a good recommendation.

@zmc zmc merged commit cb8aed3 into main Dec 20, 2023
9 checks passed
@zmc zmc deleted the systemd branch December 20, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants