Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill.kill_processes: Fix possibly-unbound variables #1906

Merged
merged 1 commit into from
Dec 27, 2023
Merged

kill.kill_processes: Fix possibly-unbound variables #1906

merged 1 commit into from
Dec 27, 2023

Conversation

zmc
Copy link
Member

@zmc zmc commented Dec 20, 2023

No description provided.

@zmc zmc requested a review from VallariAg December 21, 2023 00:23
@zmc
Copy link
Member Author

zmc commented Dec 21, 2023

https://pulpito-ng.ceph.com/zack-2023-12-21_00:49:08-orch:cephadm:smoke-main-distro-default-smithi/

VallariAg
VallariAg approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@VallariAg VallariAg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch! Tested this branch on docker setup and I was able to kill both running and queued runs.

@zmc zmc marked this pull request as ready for review December 27, 2023 17:44
@zmc zmc merged commit 01dd171 into main Dec 27, 2023
9 checks passed
@zmc zmc deleted the kill-unbound branch December 27, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VallariAg VallariAg VallariAg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmc @VallariAg