containers/teuthology-dev: Remove access token #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This container is built and pushed via GitHub Actions. GHA likes to provision a personal access token for each job that gives tightly-scoped access to the git repository to the job. When we build our container, we end up including `.git/config`, which contains the token. Later, in ceph-dev-stack's CI, an `ls-remote` is run against ceph.git, which ends up causing git to prompt for credentials even though the repo is public. Removing the token should allow reading all the relevant repos from the built container image. Signed-off-by: Zack Cerza <[email protected]>
dmick
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This container is built and pushed via GitHub Actions. GHA likes to provision a personal access token for each job that gives tightly-scoped access to the git repository to the job. When we build our container, we end up including
.git/config, which contains the token. Later, in ceph-dev-stack's CI, anls-remoteis run against ceph.git, which ends up causing git to prompt for credentials even though the repo is public. Removing the token should allow reading all the relevant repos from the built container image.