Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocproxy: route HEAD requests on the /download endpoint #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamuAlfageme
Copy link

This allows fetching metadata (size, content-type, expiration, etc.) from a public link share without the need to download it:

$ curl -I -L https://demo.owncloud.com/s/zgWp1pkJOnrWnzX/download
HTTP/2 200
content-type: application/pdf
expires: 0
pragma: public
content-length: 6657380
[...]

(Internal feature request for reference INC3001203)

Copy link
Collaborator

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With HEAD you just want the metadata, right? Because the way you implemented it looks like we're still fetching the data from EOS and maybe we should not do that. Can you confirm?
So it might not be as simple as adding this small change.. Can't we wait for OCIS in production to fulfill this request? (But then this leads us to the other discussion on the pl urls :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants