Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Updated patient resource to reflect string field character limit #414

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Updated patient resource to reflect string field character limit #414

merged 2 commits into from
Jul 6, 2020

Conversation

ebbp123
Copy link
Contributor

@ebbp123 ebbp123 commented Jul 1, 2020 •
edited by MaxPhilips
Loading

Description

The R4 documentation for Patient was updated to reflect the character limits for its string fields.

Validation

UPDATE: See #414 (comment) for updated screenshots.

The following changes are present on the body-fields table of Create section:
a) Patient.name character limits on family, given, prefix, and suffix
Screen Shot 2020-07-01 at 8 46 42 AM

b) Patient.telecom character limit on value
Patient telecom string limits

c) Patient.address character limits on line, city, district, state, postalCode, and country
Patient address string limits

PR Checklist

  • Screenshot(s) of changes attached before changes merged.
  • Screenshot(s) of changes attached after changes merged and published.

VelocityKnight
VelocityKnight suggested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@VelocityKnight VelocityKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add 'The fields' or 'The field' before each line? It's a nit but I think it would make it flow a bit more smoothly.

@MaxPhilips
Copy link
Contributor

Could you maybe add 'The fields' or 'The field' before each line? It's a nit but I think it would make it flow a bit more smoothly.

"The XXX field ... " sounds good

MaxPhilips
MaxPhilips suggested changes Jul 1, 2020
View reviewed changes
@ebbp123
Copy link
Contributor Author

ebbp123 commented Jul 1, 2020

Updated screenshots depicting requested changes:
a) Patient.name
Patient name string limits updated

b) Patient.telecom
Patient telecom string limits updated

c) Patient.address
Patient address string limits updated

@ebbp123 ebbp123 merged commit bcbc0f1 into master Jul 6, 2020
@ebbp123 ebbp123 deleted the patient-r4-write-string-limit branch July 6, 2020 13:52
@MaxPhilips MaxPhilips mentioned this pull request Jul 10, 2020
Open
ebbp123 added a commit that referenced this pull request Jul 14, 2020
@ebbp123
Generate site:
6805c9c 
* R4 CarePlan Read and Search Documentation Added (#412)
* Updated patient resource to reflect string field character limit (#414)
* Fix type of FinancialTransaction valueMoney.value examples. (#424)
* Update link for fhir-client-cerner-additions code (#428)
@MaxPhilips
Copy link
Contributor

Verified on live

Screen Shot 2020-07-14 at 4 23 59 PM

Manjushavrk pushed a commit that referenced this pull request Aug 5, 2020
@ebbp123 @manjushacerner
Updated patient resource to reflect string field character limit (#414)
11fd4cc 
* Updated patient resource to reflect string field character limit

* Addressed cr comments
wseymour15 pushed a commit that referenced this pull request Mar 11, 2021
@ebbp123 @wseymour15
Updated patient resource to reflect string field character limit (#414)
a97d464 
* Updated patient resource to reflect string field character limit

* Addressed cr comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MaxPhilips MaxPhilips MaxPhilips approved these changes

@VelocityKnight VelocityKnight VelocityKnight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebbp123 @MaxPhilips @VelocityKnight