Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: show more year values in the year facet #3481

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

tiborsimko
Copy link
Member

After the addition of old JADE records, we have much larger year span, and so have to show more year values in the facet. Closes #3480.

After the addition of old JADE records, we have much larger year span,
and so have to show more year values in the facet. Closes cernopendata#3480.
@@ -293,6 +293,7 @@
order=dict(_term='asc'))),
year=dict(terms=dict(
field='date_created.keyword',
size=70,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

years

After:

years-new

@rdebrand rdebrand self-requested a review November 30, 2023 16:23
Copy link
Contributor

@rdebrand rdebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tiborsimko tiborsimko merged commit ddb5ba3 into cernopendata:qa Nov 30, 2023
7 checks passed
@tiborsimko tiborsimko deleted the facet-show-more-years branch November 30, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants