-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch 'qa' #3504
Merge branch 'qa' #3504
Conversation
Adds several documentation pages and a first version of JADE logbook records. Several FIXMEs in the skeleton are to be amended by MPP in the next few weeks. Co-authored-by: Tibor Šimko <[email protected]>
Amends already-published stripping line documentation to include information for all stripping version / stream / line combinations in view of releasing six more data streams from Run1. Co-authored-by: Tibor Šimko <[email protected]>
Adds six new LHCb open data streams from Run1 for the forthcoming release. Amends abstract descriptions of previously released Run1 data streams for consistency. Co-authored-by: Tibor Šimko <[email protected]>
After the addition of old JADE records, we have much larger year span, and so have to show more year values in the facet. Closes cernopendata#3480.
* qa: docs: LHCb release announcement records: add DOIs to new LHCb streams records: add file information to new LHCb streams templates: announce 4 PB on the home page docs: fix Podman build instructions docs: add information about cleaning workspace docs: fix LHCb stream name case search: show more year values in the year facet records: complete JADE logbook descriptions records: additional LHCb Run1 open data streams docs: additional LHCb Run1 stripping information records: update JADE notebook 01 docs: update DEVELOPING guide about SELinux docs: initial JADE open data skeleton records: CMS 2016 luminosity files records: CMS 2016 luminosity record records: CMS 2016 validate runs files records: CMS 2016 validated runs records
Yes, we may need to do this eventually, e.g. if one day we shall have the LEP data on board, then we shall have more time span. For the time being I have put the same same value as in "qa", since this is an inter-branch merge. If we'd like to make a year facet slider, that would be best done via a new feature branch. Anyway I think there won't be much more years any time soon until we get some LEP data on board, so I guess we should be mostly OK for some time to come.
Hmm, there were no field removals in the merge request, only additions. For example, if you do: $ git log master.. --numstat | grep 'fixtures/data/records' | grep -v LHCb
41 41 cernopendata/modules/fixtures/data/records/jade-logbooks.json
1 1 cernopendata/modules/fixtures/data/records/jade-logbooks.json
547 0 cernopendata/modules/fixtures/data/records/jade-author-list.json
926 0 cernopendata/modules/fixtures/data/records/jade-logbooks.json
74 0 cernopendata/modules/fixtures/data/records/jade-preservation-author-list.json
39 0 cernopendata/modules/fixtures/data/records/jade-tools.json
41 0 cernopendata/modules/fixtures/data/records/cms-luminosity-information-detailed.json
54 0 cernopendata/modules/fixtures/data/records/cms-luminosity-information-detailed.json
24 0 cernopendata/modules/fixtures/data/records/cms-validated-runs-ppRun2.json
112 0 cernopendata/modules/fixtures/data/records/cms-validated-runs-ppRun2.json
$ git log master.. -p -- cernopendata/modules/fixtures/data/records/cms-luminosity-information-detailed.json
$ git log master.. -p -- cernopendata/modules/fixtures/data/records/cms-validated-runs-ppRun2.json You'll see that only additions have been done for CMS records. |
Ah, yes, this is "docs", I checked the CMS "data records" only. The removal of the feature field works OK, it only influences the position at which the news items are announced on the home page. That is to say, we "accumulate" them on PROD when deploying without cleaning the DB first: https://opendata.cern.ch/#news and when someone installs from scratch, we display only three news items. I consider this acceptable since the featured news items are ordered chronologically anyway and are only shown on the bottom of the page, hence not influencing the display much. |
docs: LHCb release announcement
records: add DOIs to new LHCb streams
records: add file information to new LHCb streams
templates: announce 4 PB on the home page
docs: fix Podman build instructions
docs: add information about cleaning workspace
docs: fix LHCb stream name case
search: show more year values in the year facet
records: complete JADE logbook descriptions
records: additional LHCb Run1 open data streams
docs: additional LHCb Run1 stripping information
records: update JADE notebook 01
docs: update DEVELOPING guide about SELinux
docs: initial JADE open data skeleton
records: CMS 2016 luminosity files
records: CMS 2016 luminosity record
records: CMS 2016 validate runs files
records: CMS 2016 validated runs records