Add secretTemplate to Certificate resources created by ingress-shim

[mangeshhambarde]

Pull Request Motivation

These are the changes for implementing #6838.

This allows ingress-shim users to set the secretTemplate field on generated Certificate resources. This makes using secret sync tools (e.g. kubernetes-reflector) much simpler for ingress-shim users.

Added a new Ingress annotation cert-manager.io/secret-template whose value is a JSON representation of secretTemplate.

Kind

feature

Release Note

Added a new Ingress annotation for copying specific Ingress annotations to Certificate's secretTemplate

[jetstack-bot]

Hi @mangeshhambarde. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SgtCoDFish]

/lgtm
/approve

Looks great, thank you for this! Feels like we can be confident about this with the tests being there 😁 🚀

[SgtCoDFish]

/ok-to-test

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[inteon]

I think it will be easier to read and create these annotations if there was a separate annotation for SecretTemplateAnnotations and SecretTemplateLabels.

[SgtCoDFish]

/test pull-cert-manager-master-e2e-v1-28-upgrade

[morgoved]

can you pls help me, i try to add this
cert-manager.io/secret-template: {"annotations": {"reflector.v1.k8s.emberstack.com/reflection-allowed": "true","reflector.v1.k8s.emberstack.com/reflection-allowed-namespaces": "istio-system"}}

in my ingress config but have this error
error converting YAML to JSON: yaml: line 14: found character that cannot start any token

[jsoref]

you might want to wrap the whole thing in '...'