Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linters #111

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Fix linters #111

merged 7 commits into from
Mar 28, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Mar 27, 2024

Reduces the list of ignored linters by fixing the go code.

inteon added 5 commits March 27, 2024 16:47
@inteon
fix ginkgolinter linter
03394e6 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gosimple linter
b7e3205 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gofmt linter
0fb881a 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gocritic linter
124e9e0 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix loggercheck linter
0fc7308 
Signed-off-by: Tim Ramlot <[email protected]>
@jetstack-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Mar 27, 2024
@inteon inteon marked this pull request as ready for review March 27, 2024 16:04
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 27, 2024
@inteon
Copy link
Member Author

inteon commented Mar 27, 2024

/retest

inteon added 2 commits March 27, 2024 19:49
@inteon
fix errcheck linter
63b5d3d 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix staticcheck linter
a82c9ab 
Signed-off-by: Tim Ramlot <[email protected]>
SgtCoDFish
SgtCoDFish approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Reviewing this commit-by-commit made it easy. Thanks!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@jetstack-bot jetstack-bot merged commit 6b624b3 into cert-manager:main Mar 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @jetstack-bot @SgtCoDFish