Make CSI driver spiffe writeFiles compatable with go-spiffe x509svid.Parse
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x509svid.Parse Signed-off-by: joshvanl <[email protected]>
jetstack-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
approved
Signed-off-by: joshvanl <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the driver writes certificate key pairs which are compatible with the go-spiffe x509svid.Parse library function.
To do this, the private key marshalling has been changed from
MarshalECPrivateKey->MarshalPKCS8PrivateKeyand PEM headerEC PRIVATE KEY->PRIVATE KEY.In order to test this, the
camanagerdriver component has been split out into its own struct. This was required since thecamanagerabsolutely needs afilesystemstorage (in order to read files back), however we need to use the storeInterfacefor thewriteKeypairfunc soInMemorycan be used for tests.filesystemis incompatible with unit tests since it requires mounts./cc @jakexks @charlieegan3