Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Helm chart OCI release to GH automation #226

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add Helm chart OCI release to GH automation #226

merged 2 commits into from
Dec 18, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Dec 11, 2024

Adds logic for pushing the Helm chart to an OCI registry (and adding a non-v-prefixed tag)

See cert-manager/makefile-modules#219 for more info.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2024
@inteon inteon force-pushed the add_helm_oci_release branch 2 times, most recently from 48dbd5f to 9a30fd8 Compare December 11, 2024 14:11
@inteon inteon force-pushed the add_helm_oci_release branch 2 times, most recently from 235ae51 to be0b080 Compare December 11, 2024 19:47
@inteon inteon requested a review from wallrj December 13, 2024 13:31
wallrj
wallrj approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the release docs. I can't see a test release, so I assume you'll test this after merging.

Looks the same as the other PRs in other repos.

/approve
/lgtm

RELEASE.md Outdated Show resolved Hide resolved
@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@inteon inteon force-pushed the add_helm_oci_release branch from ce28493 to fa75e2a Compare December 18, 2024 12:34
@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow cert-manager-prow bot merged commit ab1d31f into cert-manager:main Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish left review comments

@wallrj wallrj wallrj approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @wallrj @SgtCoDFish